Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-04 13:10:20 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #13923 - pcwalton:inline-absolute-hypothetical-margin, r=SimonSapin

Browse source 
layout: Remove margins from inline absolute hypothetical boxes.

As they're hypothetical, their margins shouldn't take up space!

Improves Google search results.

Closes #13915.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13923)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2016-10-26 12:38:09 -05:00 • committed by GitHub
commit e888b76534
4 changed files with 50 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
components/layout/fragment.rs
View file

@ -1233,7 +1233,8 @@ impl Fragment {
SpecificFragmentInfo::Table | SpecificFragmentInfo::Table |
SpecificFragmentInfo::TableCell | SpecificFragmentInfo::TableCell |
SpecificFragmentInfo::TableRow | SpecificFragmentInfo::TableRow |
SpecificFragmentInfo::TableColumn(_) => { SpecificFragmentInfo::TableColumn(_) |
SpecificFragmentInfo::InlineAbsoluteHypothetical(_) => {
self.margin.inline_start = Au(0); self.margin.inline_start = Au(0);
self.margin.inline_end = Au(0); self.margin.inline_end = Au(0);
return return

24
tests/wpt/mozilla/meta/MANIFEST.json
View file

@ -2432,6 +2432,18 @@
"url": "/_mozilla/css/inline_absolute_hypothetical_line_metrics_a.html" "url": "/_mozilla/css/inline_absolute_hypothetical_line_metrics_a.html"
} }
], ],
"css/inline_absolute_hypothetical_margin_a.html": [
{
"path": "css/inline_absolute_hypothetical_margin_a.html",
"references": [
[
"/_mozilla/css/inline_absolute_hypothetical_margin_ref.html",
"=="
]
],
"url": "/_mozilla/css/inline_absolute_hypothetical_margin_a.html"
}
],
"css/inline_absolute_hypothetical_metrics_a.html": [ "css/inline_absolute_hypothetical_metrics_a.html": [
{ {
"path": "css/inline_absolute_hypothetical_metrics_a.html", "path": "css/inline_absolute_hypothetical_metrics_a.html",
@ -16268,6 +16280,18 @@
"url": "/_mozilla/css/inline_absolute_hypothetical_line_metrics_a.html" "url": "/_mozilla/css/inline_absolute_hypothetical_line_metrics_a.html"
} }
], ],
"css/inline_absolute_hypothetical_margin_a.html": [
{
"path": "css/inline_absolute_hypothetical_margin_a.html",
"references": [
[
"/_mozilla/css/inline_absolute_hypothetical_margin_ref.html",
"=="
]
],
"url": "/_mozilla/css/inline_absolute_hypothetical_margin_a.html"
}
],
"css/inline_absolute_hypothetical_metrics_a.html": [ "css/inline_absolute_hypothetical_metrics_a.html": [
{ {
"path": "css/inline_absolute_hypothetical_metrics_a.html", "path": "css/inline_absolute_hypothetical_metrics_a.html",

14
tests/wpt/mozilla/tests/css/inline_absolute_hypothetical_margin_a.html Normal file
View file

@ -0,0 +1,14 @@
<!DOCTYPE html>
<meta charset="utf-8">
<link rel="match" href="inline_absolute_hypothetical_margin_ref.html">
<style>
div, span {
position: absolute;
}
span {
top: 0;
margin-left: 16px;
}
</style>
<div>Wikipedia<span>X</span></div>

10
tests/wpt/mozilla/tests/css/inline_absolute_hypothetical_margin_ref.html Normal file
View file

@ -0,0 +1,10 @@
<!DOCTYPE html>
<meta charset="utf-8">
<style>
span {
margin-left: 16px;
}
</style>
<div>Wikipedia<span>X</span></div>