Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 13:40:08 +01:00
Code Issues Projects Releases Packages Wiki Activity

Make ParseVec bigger.

Browse source 
MozReview-Commit-ID: DszMC031Xlj
This commit is contained in:
Bobby Holley 2017-06-02 20:02:10 -07:00
parent 852efb825f
commit e8a56e969f
1 changed files with 5 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

14
components/selectors/parser.rs
View file

@ -932,15 +932,11 @@ fn parse_selector<P, Impl>(parser: &P, input: &mut CssParser) -> Result<Selector
Ok(selector) Ok(selector)
} }
/// We use a SmallVec for parsing to avoid extra reallocs compared to using a Vec /// We make this large because the result of parsing a selector is fed into a new
/// directly. When parsing is done, we convert the SmallVec into a Vec (which is /// Arc-ed allocation, so any spilled vec would be a wasted allocation. Also,
/// free if the vec has already spilled to the heap, and more cache-friendly if /// Components are large enough that we don't have much cache locality benefit
/// it hasn't), and then steal the buffer of that vec into a boxed slice. /// from reserving stack space for fewer of them.
/// type ParseVec<Impl> = SmallVec<[Component<Impl>; 32]>;
/// If we parse N <= 4 entries, we save no reallocations.
/// If we parse 4 < N <= 8 entries, we save one reallocation.
/// If we parse N > 8 entries, we save two reallocations.
type ParseVec<Impl> = SmallVec<[Component<Impl>; 8]>;
/// Parses a complex selector, including any pseudo-element. /// Parses a complex selector, including any pseudo-element.
/// ///