From e8e4cb726b0d6f990265b5740476ba062c6df085 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Simon=20W=C3=BClker?= <simon.wuelker@arcor.de>
Date: Mon, 13 Jan 2025 17:27:31 +0100
Subject: [PATCH] Remove incorrect TODO comment in htmlinputelement.rs (#34970)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* Add doc comments to InputType

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Add doc comment to HtmlInputElement::checked_changed

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Remove incorrect TODO comment

The comment indicated that we should fire a change
event at a radio input when changed the checkedness.

This is incorrect, as events should only be fired as
part of the input element's activation behaviour.

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

---------

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
---
 components/script/dom/htmlinputelement.rs | 47 ++++++++++++++++++++++-
 1 file changed, 46 insertions(+), 1 deletion(-)

diff --git a/components/script/dom/htmlinputelement.rs b/components/script/dom/htmlinputelement.rs
index f1c60627082..7c4a1a626cd 100644
--- a/components/script/dom/htmlinputelement.rs
+++ b/components/script/dom/htmlinputelement.rs
@@ -85,32 +85,76 @@ const DEFAULT_SUBMIT_VALUE: &str = "Submit";
 const DEFAULT_RESET_VALUE: &str = "Reset";
 const PASSWORD_REPLACEMENT_CHAR: char = '●';
 
+/// <https://html.spec.whatwg.org/multipage/#attr-input-type>
 #[derive(Clone, Copy, Default, JSTraceable, PartialEq)]
 #[allow(dead_code)]
 #[derive(MallocSizeOf)]
 pub(crate) enum InputType {
+    /// <https://html.spec.whatwg.org/multipage/#button-state-(type=button)>
     Button,
+
+    /// <https://html.spec.whatwg.org/multipage/#checkbox-state-(type=checkbox)>
     Checkbox,
+
+    /// <https://html.spec.whatwg.org/multipage/#color-state-(type=color)>
     Color,
+
+    /// <https://html.spec.whatwg.org/multipage/#date-state-(type=date)>
     Date,
+
+    /// <https://html.spec.whatwg.org/multipage/#local-date-and-time-state-(type=datetime-local)>
     DatetimeLocal,
+
+    /// <https://html.spec.whatwg.org/multipage/#email-state-(type=email)>
     Email,
+
+    /// <https://html.spec.whatwg.org/multipage/#file-upload-state-(type=file)>
     File,
+
+    /// <https://html.spec.whatwg.org/multipage/#hidden-state-(type=hidden)>
     Hidden,
+
+    /// <https://html.spec.whatwg.org/multipage/#image-button-state-(type=image)>
     Image,
+
+    /// <https://html.spec.whatwg.org/multipage/#month-state-(type=month)>
     Month,
+
+    /// <https://html.spec.whatwg.org/multipage/#number-state-(type=number)>
     Number,
+
+    /// <https://html.spec.whatwg.org/multipage/#password-state-(type=password)>
     Password,
+
+    /// <https://html.spec.whatwg.org/multipage/#radio-button-state-(type=radio)>
     Radio,
+
+    /// <https://html.spec.whatwg.org/multipage/#range-state-(type=range)>
     Range,
+
+    /// <https://html.spec.whatwg.org/multipage/#reset-button-state-(type=reset)>
     Reset,
+
+    /// <https://html.spec.whatwg.org/multipage/#text-(type=text)-state-and-search-state-(type=search)>
     Search,
+
+    /// <https://html.spec.whatwg.org/multipage/#submit-button-state-(type=submit)>
     Submit,
+
+    /// <https://html.spec.whatwg.org/multipage/#telephone-state-(type=tel)>
     Tel,
+
+    /// <https://html.spec.whatwg.org/multipage/#text-(type=text)-state-and-search-state-(type=search)>
     #[default]
     Text,
+
+    /// <https://html.spec.whatwg.org/multipage/#time-state-(type=time)>
     Time,
+
+    /// <https://html.spec.whatwg.org/multipage/#url-state-(type=url)>
     Url,
+
+    /// <https://html.spec.whatwg.org/multipage/#week-state-(type=week)>
     Week,
 }
 
@@ -242,6 +286,8 @@ enum StepDirection {
 pub(crate) struct HTMLInputElement {
     htmlelement: HTMLElement,
     input_type: Cell<InputType>,
+
+    /// <https://html.spec.whatwg.org/multipage/#concept-input-checked-dirty-flag>
     checked_changed: Cell<bool>,
     placeholder: DomRefCell<DOMString>,
     size: Cell<u32>,
@@ -1801,7 +1847,6 @@ impl HTMLInputElement {
         }
 
         self.upcast::<Node>().dirty(NodeDamage::OtherNodeDamage);
-        //TODO: dispatch change event
     }
 
     // https://html.spec.whatwg.org/multipage/#concept-fe-mutable