Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-22 23:03:42 +01:00
Code Issues Projects Releases Packages Wiki Activity

script: Expose node helpers as NodeTraits and give more descriptive names (#34832)

Browse source 
This puts a few commonly used `Node` helpers into a trait (`NodeTraits`)
and gives them more descriptive names and documentation. The renames:

- `document_from_node` -> `NodeTraits::owner_document`
- `window_from_node` -> `NodeTraits::owner_window`
- `stylesheets_owner_from_node<T:` -> `NodeTraits::stylesheet_list_owner`
- `containing_shadow_root` -> `NodeTraits::containing_shadow_root`

Signed-off-by: Martin Robinson <mrobinson@igalia.com>
This commit is contained in:
Martin Robinson 2025-01-03 19:55:01 +01:00 • committed by GitHub
parent 621ddd749c
commit e8f75c9aea
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
66 changed files with 415 additions and 426 deletions
Download patch file Download diff file Expand all files Collapse all files

12
components/script/devtools.rs
View file

@ -37,7 +37,7 @@ use crate::dom::document::AnimationFrameCallback;
use crate::dom::element::Element;
use crate::dom::globalscope::GlobalScope;
use crate::dom::htmlscriptelement::SourceCode;
use crate::dom::node::{stylesheets_owner_from_node, window_from_node, Node, ShadowIncluding};
use crate::dom::node::{Node, NodeTraits, ShadowIncluding};
use crate::dom::types::HTMLElement;
use crate::realms::enter_realm;
use crate::script_module::ScriptFetchOptions;
@ -152,7 +152,7 @@ pub fn handle_get_children(
let inline: Vec<_> = parent
.children()
.map(|child| {
let window = window_from_node(&*child);
let window = child.owner_window();
let Some(elem) = child.downcast::<Element>() else {
return false;
};
@ -231,7 +231,7 @@ pub fn handle_get_stylesheet_style(
let document = documents.find_document(pipeline)?;
let _realm = enter_realm(document.window());
let owner = stylesheets_owner_from_node(&*node);
let owner = node.stylesheet_list_owner();
let stylesheet = owner.stylesheet_at(stylesheet)?;
let list = stylesheet.GetCssRules().ok()?;
@ -275,7 +275,7 @@ pub fn handle_get_selectors(
let document = documents.find_document(pipeline)?;
let _realm = enter_realm(document.window());
let owner = stylesheets_owner_from_node(&*node);
let owner = node.stylesheet_list_owner();
let rules = (0..owner.stylesheet_count())
.filter_map(|i| {
@ -312,7 +312,7 @@ pub fn handle_get_computed_style(
Some(found_node) => found_node,
};
let window = window_from_node(&*node);
let window = node.owner_window();
let elem = node
.downcast::<Element>()
.expect("This should be an element");
@ -353,7 +353,7 @@ pub fn handle_get_layout(
let width = rect.Width() as f32;
let height = rect.Height() as f32;
let window = window_from_node(&*node);
let window = node.owner_window();
let elem = node
.downcast::<Element>()
.expect("should be getting layout of element");