mirror of
https://github.com/servo/servo.git
synced 2025-08-06 14:10:11 +01:00
script: Expose node helpers as NodeTraits
and give more descriptive names (#34832)
This puts a few commonly used `Node` helpers into a trait (`NodeTraits`) and gives them more descriptive names and documentation. The renames: - `document_from_node` -> `NodeTraits::owner_document` - `window_from_node` -> `NodeTraits::owner_window` - `stylesheets_owner_from_node<T:` -> `NodeTraits::stylesheet_list_owner` - `containing_shadow_root` -> `NodeTraits::containing_shadow_root` Signed-off-by: Martin Robinson <mrobinson@igalia.com>
This commit is contained in:
parent
621ddd749c
commit
e8f75c9aea
66 changed files with 415 additions and 426 deletions
|
@ -19,7 +19,7 @@ use crate::dom::element::{Element, LayoutElementHelpers};
|
|||
use crate::dom::htmlcollection::HTMLCollection;
|
||||
use crate::dom::htmlelement::HTMLElement;
|
||||
use crate::dom::htmltablerowelement::HTMLTableRowElement;
|
||||
use crate::dom::node::{window_from_node, Node};
|
||||
use crate::dom::node::{Node, NodeTraits};
|
||||
use crate::dom::virtualmethods::VirtualMethods;
|
||||
use crate::script_runtime::CanGc;
|
||||
|
||||
|
@ -64,14 +64,10 @@ impl HTMLTableSectionElement {
|
|||
impl HTMLTableSectionElementMethods<crate::DomTypeHolder> for HTMLTableSectionElement {
|
||||
// https://html.spec.whatwg.org/multipage/#dom-tbody-rows
|
||||
fn Rows(&self) -> DomRoot<HTMLCollection> {
|
||||
HTMLCollection::new_with_filter_fn(
|
||||
&window_from_node(self),
|
||||
self.upcast(),
|
||||
|element, root| {
|
||||
element.is::<HTMLTableRowElement>() &&
|
||||
element.upcast::<Node>().GetParentNode().as_deref() == Some(root)
|
||||
},
|
||||
)
|
||||
HTMLCollection::new_with_filter_fn(&self.owner_window(), self.upcast(), |element, root| {
|
||||
element.is::<HTMLTableRowElement>() &&
|
||||
element.upcast::<Node>().GetParentNode().as_deref() == Some(root)
|
||||
})
|
||||
}
|
||||
|
||||
// https://html.spec.whatwg.org/multipage/#dom-tbody-insertrow
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue