mirror of
https://github.com/servo/servo.git
synced 2025-08-03 04:30:10 +01:00
script: Expose node helpers as NodeTraits
and give more descriptive names (#34832)
This puts a few commonly used `Node` helpers into a trait (`NodeTraits`) and gives them more descriptive names and documentation. The renames: - `document_from_node` -> `NodeTraits::owner_document` - `window_from_node` -> `NodeTraits::owner_window` - `stylesheets_owner_from_node<T:` -> `NodeTraits::stylesheet_list_owner` - `containing_shadow_root` -> `NodeTraits::containing_shadow_root` Signed-off-by: Martin Robinson <mrobinson@igalia.com>
This commit is contained in:
parent
621ddd749c
commit
e8f75c9aea
66 changed files with 415 additions and 426 deletions
|
@ -128,7 +128,7 @@ macro_rules! make_form_action_getter(
|
|||
use $crate::dom::bindings::inheritance::Castable;
|
||||
use $crate::dom::element::Element;
|
||||
let element = self.upcast::<Element>();
|
||||
let doc = $crate::dom::node::document_from_node(self);
|
||||
let doc = $crate::dom::node::NodeTraits::owner_document(self);
|
||||
let attr = element.get_attribute(&html5ever::ns!(), &html5ever::local_name!($htmlname));
|
||||
let value = attr.as_ref().map(|attr| attr.value());
|
||||
let value = match value {
|
||||
|
@ -410,7 +410,7 @@ macro_rules! define_event_handler(
|
|||
macro_rules! define_window_owned_event_handler(
|
||||
($handler: ty, $event_type: ident, $getter: ident, $setter: ident) => (
|
||||
fn $getter(&self) -> Option<::std::rc::Rc<$handler>> {
|
||||
let document = document_from_node(self);
|
||||
let document = self.owner_document();
|
||||
if document.has_browsing_context() {
|
||||
document.window().$getter()
|
||||
} else {
|
||||
|
@ -419,7 +419,7 @@ macro_rules! define_window_owned_event_handler(
|
|||
}
|
||||
|
||||
fn $setter(&self, listener: Option<::std::rc::Rc<$handler>>) {
|
||||
let document = document_from_node(self);
|
||||
let document = self.owner_document();
|
||||
if document.has_browsing_context() {
|
||||
document.window().$setter(listener)
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue