Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 04:30:10 +01:00
Code Issues Projects Releases Packages Wiki Activity

devtools: improve ID Naming for better readability and context (#35942)

Browse source 
Signed-off-by: atbrakhi <atbrakhi@igalia.com>
This commit is contained in:
atbrakhi 2025-03-13 08:36:54 +01:00 • committed by GitHub
parent 7594dc6991
commit eb2ca42824
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
7 changed files with 60 additions and 60 deletions
Download patch file Download diff file Expand all files Collapse all files

12
components/devtools/actors/browsing_context.rs
View file

@ -173,9 +173,9 @@ impl Actor for BrowsingContextActor {
impl BrowsingContextActor {
pub(crate) fn new(
console: String,
id: BrowsingContextId,
browsing_context_id: BrowsingContextId,
page_info: DevtoolsPageInfo,
pipeline: PipelineId,
pipeline_id: PipelineId,
script_sender: IpcSender<DevtoolScriptControlMsg>,
actors: &mut ActorRegistry,
) -> BrowsingContextActor {
@ -224,8 +224,8 @@ impl BrowsingContextActor {
script_chan: script_sender,
title: RefCell::new(title),
url: RefCell::new(url.into_string()),
active_pipeline: Cell::new(pipeline),
browsing_context_id: id,
active_pipeline: Cell::new(pipeline_id),
browsing_context_id,
accessibility: accessibility.name(),
console,
css_properties: css_properties.name(),
@ -308,8 +308,8 @@ impl BrowsingContextActor {
}
}
pub(crate) fn title_changed(&self, pipeline: PipelineId, title: String) {
if pipeline != self.active_pipeline.get() {
pub(crate) fn title_changed(&self, pipeline_id: PipelineId, title: String) {
if pipeline_id != self.active_pipeline.get() {
return;
}
*self.title.borrow_mut() = title;