Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-22 23:03:42 +01:00
Code Issues Projects Releases Packages Wiki Activity

Rewrite the ban-type lint in Python

Browse source 
Delete old rust ban lint and move tests to python tidy

Fix ban lint regex and fix test
This commit is contained in:
Jefry Lagrange 2017-02-19 10:54:59 +01:00
parent 26de7c6bc4
commit ebcb15d6f2
6 changed files with 18 additions and 56 deletions
Download patch file Download diff file Expand all files Collapse all files

8
python/tidy/servo_tidy_tests/test_tidy.py
View file

@ -140,6 +140,14 @@ class CheckTidiness(unittest.TestCase):
self.assertTrue('feature attribute is not in alphabetical order' in feature_errors.next()[2])
self.assertNoMoreErrors(feature_errors)
ban_errors = tidy.collect_errors_for_files(iterFile('ban.rs'), [], [tidy.check_rust], print_text=False)
self.assertEqual('Banned type Cell<JSVal> detected. Use MutJS<JSVal> instead', ban_errors.next()[2])
self.assertNoMoreErrors(ban_errors)
ban_errors = tidy.collect_errors_for_files(iterFile('ban-domrefcell.rs'), [], [tidy.check_rust], print_text=False)
self.assertEqual('Banned type DOMRefCell<JS<T>> detected. Use MutJS<JS<T>> instead', ban_errors.next()[2])
self.assertNoMoreErrors(ban_errors)
def test_spec_link(self):
tidy.SPEC_BASE_PATH = base_path
errors = tidy.collect_errors_for_files(iterFile('speclink.rs'), [], [tidy.check_spec], print_text=False)