From ebe5f85ac59ba6de62bef850a159a121c1e9e90d Mon Sep 17 00:00:00 2001 From: Anthony Ramine Date: Tue, 8 Nov 2016 09:20:23 +0100 Subject: [PATCH] Fix the URL port setter tests https://github.com/whatwg/url/pull/113 --- tests/wpt/metadata/url/url-setters.html.ini | 6 ------ .../web-platform-tests/url/setters_tests.json | 16 ++++++++-------- 2 files changed, 8 insertions(+), 14 deletions(-) diff --git a/tests/wpt/metadata/url/url-setters.html.ini b/tests/wpt/metadata/url/url-setters.html.ini index 1f6563a640f..8831fae8677 100644 --- a/tests/wpt/metadata/url/url-setters.html.ini +++ b/tests/wpt/metadata/url/url-setters.html.ini @@ -6,12 +6,6 @@ [Setting .protocol = 'http' Can’t switch from non-special scheme to special. Note: this may change, see https://github.com/whatwg/url/issues/104] expected: FAIL - [Setting .host = 'example.com:' Port number is unchanges if empty in the new value. Note: this may change, see https://github.com/whatwg/url/pull/113] - expected: FAIL - - [Setting .port = '' Port number is unchanged if empty in the new value. Note: this may change, see https://github.com/whatwg/url/pull/113] - expected: FAIL - [Setting .pathname = '\x00\x01\t\n\r\x1f !"#$%&'()*+,-./09:;<=>?@AZ[\\\]^_`az{|}~€Éé' UTF-8 percent encoding with the default encode set. Tabs and newlines are removed.] expected: FAIL diff --git a/tests/wpt/web-platform-tests/url/setters_tests.json b/tests/wpt/web-platform-tests/url/setters_tests.json index 9512d2547e3..a62210ec6b3 100644 --- a/tests/wpt/web-platform-tests/url/setters_tests.json +++ b/tests/wpt/web-platform-tests/url/setters_tests.json @@ -346,14 +346,14 @@ } }, { - "comment": "Port number is unchanges if empty in the new value. Note: this may change, see https://github.com/whatwg/url/pull/113", + "comment": "Port number is removed if empty in the new value", "href": "http://example.net:8080", "new_value": "example.com:", "expected": { - "href": "http://example.com:8080/", - "host": "example.com:8080", + "href": "http://example.com/", + "host": "example.com", "hostname": "example.com", - "port": "8080" + "port": "" } }, { @@ -761,14 +761,14 @@ } }, { - "comment": "Port number is unchanged if empty in the new value. Note: this may change, see https://github.com/whatwg/url/pull/113", + "comment": "Port number is removed if empty in the new value", "href": "http://example.net:8080", "new_value": "", "expected": { - "href": "http://example.net:8080/", - "host": "example.net:8080", + "href": "http://example.net/", + "host": "example.net", "hostname": "example.net", - "port": "8080" + "port": "" } }, {