webgpu: Move actual Create* implementations from GPUDevice to Self (#33320)

* Move actual Create* implementations from `GPUDevice` to Self

Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>

* move Create*Pipeline to Self::create

Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>

* `parse_render_pipeline` outside`GPURenderPipeline::create`

Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>

---------

Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
This commit is contained in:
Samson 2024-09-05 21:48:16 +02:00 committed by GitHub
parent 312cf0df08
commit ebed9218f2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
14 changed files with 594 additions and 486 deletions

View file

@ -10,12 +10,18 @@ use webgpu::{WebGPU, WebGPURequest, WebGPUResponse, WebGPUShaderModule};
use super::gpu::AsyncWGPUListener;
use super::gpucompilationinfo::GPUCompilationInfo;
use super::promise::Promise;
use super::types::GPUDevice;
use crate::dom::bindings::cell::DomRefCell;
use crate::dom::bindings::codegen::Bindings::WebGPUBinding::GPUShaderModuleMethods;
use crate::dom::bindings::codegen::Bindings::WebGPUBinding::{
GPUShaderModuleDescriptor, GPUShaderModuleMethods,
};
use crate::dom::bindings::reflector::{reflect_dom_object, DomObject, Reflector};
use crate::dom::bindings::root::DomRoot;
use crate::dom::bindings::str::USVString;
use crate::dom::bindings::trace::RootedTraceableBox;
use crate::dom::globalscope::GlobalScope;
use crate::dom::gpu::response_async;
use crate::realms::InRealm;
#[dom_struct]
pub struct GPUShaderModule {
@ -69,6 +75,39 @@ impl GPUShaderModule {
pub fn id(&self) -> WebGPUShaderModule {
self.shader_module
}
/// <https://gpuweb.github.io/gpuweb/#dom-gpudevice-createshadermodule>
pub fn create(
device: &GPUDevice,
descriptor: RootedTraceableBox<GPUShaderModuleDescriptor>,
comp: InRealm,
) -> DomRoot<GPUShaderModule> {
let program_id = device
.global()
.wgpu_id_hub()
.create_shader_module_id(device.id().0.backend());
let promise = Promise::new_in_current_realm(comp);
let shader_module = GPUShaderModule::new(
&device.global(),
device.channel().clone(),
WebGPUShaderModule(program_id),
descriptor.parent.label.clone(),
promise.clone(),
);
let sender = response_async(&promise, &*shader_module);
device
.channel()
.0
.send(WebGPURequest::CreateShaderModule {
device_id: device.id().0,
program_id,
program: descriptor.code.0.clone(),
label: None,
sender,
})
.expect("Failed to create WebGPU ShaderModule");
shader_module
}
}
impl GPUShaderModuleMethods for GPUShaderModule {