From 839830d1d8891fef7be5b7c0d3edca2bef202685 Mon Sep 17 00:00:00 2001 From: Ms2ger Date: Fri, 10 Apr 2015 09:20:26 +0200 Subject: [PATCH] Fix typo in the substringData implementation. --- components/script/dom/characterdata.rs | 2 +- .../metadata/dom/nodes/CharacterData-substringData.html.ini | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) delete mode 100644 tests/wpt/metadata/dom/nodes/CharacterData-substringData.html.ini diff --git a/components/script/dom/characterdata.rs b/components/script/dom/characterdata.rs index 172fda96f47..92f3283c759 100644 --- a/components/script/dom/characterdata.rs +++ b/components/script/dom/characterdata.rs @@ -73,7 +73,7 @@ impl<'a> CharacterDataMethods for JSRef<'a, CharacterData> { let data = self.data.borrow(); // Step 1. let len = data.chars().count(); - if len > offset as usize { + if offset as usize > len { // Step 2. return Err(IndexSize); } diff --git a/tests/wpt/metadata/dom/nodes/CharacterData-substringData.html.ini b/tests/wpt/metadata/dom/nodes/CharacterData-substringData.html.ini deleted file mode 100644 index 236aa95dfa3..00000000000 --- a/tests/wpt/metadata/dom/nodes/CharacterData-substringData.html.ini +++ /dev/null @@ -1,3 +0,0 @@ -[CharacterData-substringData.html] - type: testharness - expected: CRASH