mirror of
https://github.com/servo/servo.git
synced 2025-08-06 06:00:15 +01:00
Auto merge of #20182 - paulrouget:ctrl_l, r=jdm
Prompt URL on Cmd/Ctrl-L <!-- Please describe your changes on the following line: --> The `sanitize_url` code is very naive. I'm sure we can do better. This ServoShell issue describes the problem: https://github.com/paulrouget/servoshell/issues/59 I can fix that now if someone can help me figure out how to tell if a string is a valid url which is just missing a scheme. Or we can do that in a follow up. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #20165 <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20182) <!-- Reviewable:end -->
This commit is contained in:
commit
ec3aa8bd7a
8 changed files with 46 additions and 8 deletions
|
@ -19,4 +19,4 @@ servo_rand = {path = "../rand"}
|
|||
uuid = {version = "0.5", features = ["v4"]}
|
||||
|
||||
[target.'cfg(target_os = "linux")'.dependencies]
|
||||
tinyfiledialogs = "2.5.9"
|
||||
tinyfiledialogs = "3.0"
|
||||
|
|
|
@ -44,7 +44,7 @@ uuid = {version = "0.5", features = ["v4"]}
|
|||
webrender_api = {git = "https://github.com/servo/webrender", features = ["ipc"]}
|
||||
|
||||
[target.'cfg(any(target_os = "macos", target_os = "linux", target_os = "windows"))'.dependencies]
|
||||
tinyfiledialogs = "2.5.9"
|
||||
tinyfiledialogs = "3.0"
|
||||
|
||||
[[test]]
|
||||
name = "main"
|
||||
|
|
|
@ -24,7 +24,7 @@ phf_shared = "0.7.18"
|
|||
serde_json = "1.0"
|
||||
|
||||
[target.'cfg(any(target_os = "macos", target_os = "linux", target_os = "windows"))'.dependencies]
|
||||
tinyfiledialogs = "2.5.9"
|
||||
tinyfiledialogs = "3.0"
|
||||
|
||||
[dependencies]
|
||||
app_units = "0.6"
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue