From 82335a1904a092da76ba687090834d0123f53d48 Mon Sep 17 00:00:00 2001 From: Corey Farwell Date: Thu, 9 Apr 2015 10:16:10 -0700 Subject: [PATCH] Spec links for script::dom::element & script::dom::event --- components/script/dom/element.rs | 9 ++++++++- components/script/dom/event.rs | 13 +++++++++++++ 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/components/script/dom/element.rs b/components/script/dom/element.rs index 418dd124158..405ed80b95f 100644 --- a/components/script/dom/element.rs +++ b/components/script/dom/element.rs @@ -934,6 +934,7 @@ impl<'a> ElementMethods for JSRef<'a, Element> { } } + // https://dom.spec.whatwg.org/#dom-element-localname fn LocalName(self) -> DOMString { self.local_name.as_slice().to_owned() } @@ -1079,17 +1080,20 @@ impl<'a> ElementMethods for JSRef<'a, Element> { self.GetAttributeNS(namespace, local_name).is_some() } + // https://dom.spec.whatwg.org/#dom-element-getelementsbytagname fn GetElementsByTagName(self, localname: DOMString) -> Temporary { let window = window_from_node(self).root(); HTMLCollection::by_tag_name(window.r(), NodeCast::from_ref(self), localname) } + // https://dom.spec.whatwg.org/#dom-element-getelementsbytagnamens fn GetElementsByTagNameNS(self, maybe_ns: Option, localname: DOMString) -> Temporary { let window = window_from_node(self).root(); HTMLCollection::by_tag_name_ns(window.r(), NodeCast::from_ref(self), localname, maybe_ns) } + // https://dom.spec.whatwg.org/#dom-element-getelementsbyclassname fn GetElementsByClassName(self, classes: DOMString) -> Temporary { let window = window_from_node(self).root(); HTMLCollection::by_class_name(window.r(), NodeCast::from_ref(self), classes) @@ -1126,12 +1130,13 @@ impl<'a> ElementMethods for JSRef<'a, Element> { rect.origin.x + rect.size.width) } - // https://dvcs.w3.org/hg/innerhtml/raw-file/tip/index.html#extensions-to-the-element-interface + // https://dvcs.w3.org/hg/innerhtml/raw-file/tip/index.html#widl-Element-innerHTML fn GetInnerHTML(self) -> Fallible { //XXX TODO: XML case self.serialize(ChildrenOnly) } + // https://dvcs.w3.org/hg/innerhtml/raw-file/tip/index.html#widl-Element-innerHTML fn SetInnerHTML(self, value: DOMString) -> Fallible<()> { let context_node: JSRef = NodeCast::from_ref(self); // Step 1. @@ -1141,10 +1146,12 @@ impl<'a> ElementMethods for JSRef<'a, Element> { Ok(()) } + // https://dvcs.w3.org/hg/innerhtml/raw-file/tip/index.html#widl-Element-outerHTML fn GetOuterHTML(self) -> Fallible { self.serialize(IncludeNode) } + // https://dvcs.w3.org/hg/innerhtml/raw-file/tip/index.html#widl-Element-outerHTML fn SetOuterHTML(self, value: DOMString) -> Fallible<()> { let context_document = document_from_node(self).root(); let context_node: JSRef = NodeCast::from_ref(self); diff --git a/components/script/dom/event.rs b/components/script/dom/event.rs index aa588d09984..6c2e6fa860f 100644 --- a/components/script/dom/event.rs +++ b/components/script/dom/event.rs @@ -174,55 +174,67 @@ impl Event { } impl<'a> EventMethods for JSRef<'a, Event> { + // https://dom.spec.whatwg.org/#dom-event-eventphase fn EventPhase(self) -> u16 { self.phase.get() as u16 } + // https://dom.spec.whatwg.org/#dom-event-type fn Type(self) -> DOMString { // FIXME(https://github.com/rust-lang/rust/issues/23338) let type_ = self.type_.borrow(); type_.clone() } + // https://dom.spec.whatwg.org/#dom-event-target fn GetTarget(self) -> Option> { self.target.get() } + // https://dom.spec.whatwg.org/#dom-event-currenttarget fn GetCurrentTarget(self) -> Option> { self.current_target.get() } + // https://dom.spec.whatwg.org/#dom-event-defaultprevented fn DefaultPrevented(self) -> bool { self.canceled.get() } + // https://dom.spec.whatwg.org/#dom-event-preventdefault fn PreventDefault(self) { if self.cancelable.get() { self.canceled.set(true) } } + // https://dom.spec.whatwg.org/#dom-event-stoppropagation fn StopPropagation(self) { self.stop_propagation.set(true); } + // https://dom.spec.whatwg.org/#dom-event-stopimmediatepropagation fn StopImmediatePropagation(self) { self.stop_immediate.set(true); self.stop_propagation.set(true); } + // https://dom.spec.whatwg.org/#dom-event-bubbles fn Bubbles(self) -> bool { self.bubbles.get() } + // https://dom.spec.whatwg.org/#dom-event-cancelable fn Cancelable(self) -> bool { self.cancelable.get() } + // https://dom.spec.whatwg.org/#dom-event-timestamp fn TimeStamp(self) -> u64 { self.timestamp } + // https://dom.spec.whatwg.org/#dom-event-initevent fn InitEvent(self, type_: DOMString, bubbles: bool, @@ -242,6 +254,7 @@ impl<'a> EventMethods for JSRef<'a, Event> { self.cancelable.set(cancelable); } + // https://dom.spec.whatwg.org/#dom-event-istrusted fn IsTrusted(self) -> bool { self.trusted.get() }