mirror of
https://github.com/servo/servo.git
synced 2025-08-03 12:40:06 +01:00
layout: Check if root before establishing containing block (#36360)
As per [w3.org/TR/filter-effects-1#FilterProperty](https://www.w3.org/TR/filter-effects-1/#FilterProperty), `filter` shouldn't make the root element establish a containing block for absolute and fixed positioned descendants. `will-change: filter` has matching behavior. This PR adds a check for if we are the root element before establishing such a block. To know if we are the root element, we look at the `FragmentFlags` passed in. Previously for our function, these were dummy flags, always constructed as empty. Thus, this PR also makes sure the correct FragmentFlags are passed down the chain to the function `establishes_containing_block_for_all_descendants`. Testing: - `/css/filter-effects/filtered-html-is-not-container.html` now passes - `/css/css-will-change/will-change-fixedpos-cb-003.html` now passes - Manual tests are working Fixes: #35391 --------- Signed-off-by: haval0 <56519858+haval0@users.noreply.github.com> Signed-off-by: Oriol Brufau <obrufau@igalia.com> Co-authored-by: Oriol Brufau <obrufau@igalia.com>
This commit is contained in:
parent
bab788f5d5
commit
ec88b5d752
11 changed files with 44 additions and 35 deletions
|
@ -326,13 +326,12 @@ impl LineItemLayout<'_, '_> {
|
|||
let inline_box = self.layout.ifc.inline_boxes.get(identifier);
|
||||
let inline_box = &*(inline_box.borrow());
|
||||
|
||||
let style = &inline_box.base.style;
|
||||
let space_above_baseline = inline_box_state.calculate_space_above_baseline();
|
||||
let block_start_offset =
|
||||
self.calculate_inline_box_block_start(inline_box_state, space_above_baseline);
|
||||
|
||||
let positioning_context_or_start_offset_in_parent =
|
||||
match PositioningContext::new_for_style(style) {
|
||||
match inline_box.base.new_positioning_context() {
|
||||
Some(positioning_context) => Either::Left(positioning_context),
|
||||
None => Either::Right(self.current_positioning_context_mut().len()),
|
||||
};
|
||||
|
|
|
@ -2004,7 +2004,8 @@ impl IndependentFormattingContext {
|
|||
bidi_level: Level,
|
||||
) {
|
||||
// We need to know the inline size of the atomic before deciding whether to do the line break.
|
||||
let mut child_positioning_context = PositioningContext::new_for_style(self.style())
|
||||
let mut child_positioning_context = self
|
||||
.new_positioning_context()
|
||||
.unwrap_or_else(|| PositioningContext::new_for_subtree(true));
|
||||
let IndependentFloatOrAtomicLayoutResult {
|
||||
mut fragment,
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue