Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-30 08:39:16 +01:00
Code Issues Projects Releases Packages Wiki Activity

Propagate destination through load_data (#37020)

Browse source 
This way, we don't always set the destination to Document (which is as
the spec is written today). Instead, we set it it in the load_data,
depending on which context we load it from.

Doing so allows us to set the `Destination::IFrame` for navigations in
iframes, enabling all frame-related CSP checks.

While we currently block iframes when `frame-src` or `child-src` is set,
their respective tests don't pass yet. That's because we don't yet
handle the cases
where we fire the correct `load` event.

Also update one WPT test to correctly fail, rather than erroring. That's
because it was using the wrong JS test variable.

Part of #4577

Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
Co-authored-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Tim van der Lippe 2025-05-17 10:22:11 +02:00 • committed by GitHub
parent a028291466
commit ed469fe72f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
7 changed files with 17 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

2
tests/wpt/meta/MANIFEST.json vendored
View file

@ -567585,7 +567585,7 @@
]
],
"frame-src-blocked.sub.html": [
"a4957f8715c4bdc0db9473caee3fc9f2e767fd71",
"76fcc2cbb536ba9ec0c8741ad9fe9af470165d32",
[
null,
{}

1
tests/wpt/meta/content-security-policy/frame-src/frame-src-blocked.sub.html.ini vendored
View file

@ -1,4 +1,3 @@
[frame-src-blocked.sub.html]
expected: ERROR
[Expecting logs: ["PASS IFrame #1 generated a load event.","violated-directive=frame-src"\]]
expected: FAIL

4
tests/wpt/meta/content-security-policy/frame-src/frame-src-cross-origin-same-document-navigation.window.js.ini vendored
View file

@ -1,4 +1,4 @@
[frame-src-cross-origin-same-document-navigation.window.html]
expected: OK
expected: TIMEOUT
[frame-src-cross-origin-same-document-navigation]
expected: FAIL
expected: TIMEOUT

6
tests/wpt/tests/content-security-policy/frame-src/frame-src-blocked.sub.html vendored
View file

@ -18,17 +18,17 @@
}, false);
function alert_assert(msg) {
t_alert.step(function() {
t_log.step(function() {
if (msg.match(/^FAIL/i)) {
assert_unreached(msg);
t_alert.done();
t_log.done();
}
for (var i = 0; i < expected_alerts.length; i++) {
if (expected_alerts[i] == msg) {
assert_equals(expected_alerts[i], msg);
expected_alerts.splice(i, 1);
if (expected_alerts.length == 0) {
t_alert.done();
t_log.done();
}
return;
}