Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-23 07:13:52 +01:00
Code Issues Projects Releases Packages Wiki Activity

Add the type IDL attribute to htmlfieldsetelement (#32869)

Browse source 
* Add the type IDL attribute to htmlfieldsetelement

Signed-off-by: Shane Handley <shanehandley@fastmail.com>

* Fix missing idlharness test expectations

Signed-off-by: Shane Handley <shanehandley@fastmail.com>

---------

Signed-off-by: Shane Handley <shanehandley@fastmail.com>
This commit is contained in:
shanehandley 2024-07-29 01:01:01 +10:00 • committed by GitHub
parent bc75bf4cfa
commit ed8def2896
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 6 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

5
components/script/dom/htmlfieldsetelement.rs
View file

@ -144,6 +144,11 @@ impl HTMLFieldSetElementMethods for HTMLFieldSetElement {
fn SetCustomValidity(&self, error: DOMString) {
self.validity_state().set_custom_error_message(error);
}
/// <https://html.spec.whatwg.org/multipage/#dom-fieldset-type>
fn Type(&self) -> DOMString {
DOMString::from_string(String::from("fieldset"))
}
}
impl VirtualMethods for HTMLFieldSetElement {

2
components/script/dom/webidls/HTMLFieldSetElement.webidl
View file

@ -13,7 +13,7 @@ interface HTMLFieldSetElement : HTMLElement {
[CEReactions]
attribute DOMString name;
//readonly attribute DOMString type;
readonly attribute DOMString type;
[SameObject] readonly attribute HTMLCollection elements;

3
tests/wpt/meta-legacy-layout/html/dom/idlharness.https.html.ini vendored
View file

@ -2979,9 +2979,6 @@
[HTMLEmbedElement interface: document.createElement("embed") must inherit property "name" with the proper type]
expected: FAIL
[HTMLFieldSetElement interface: attribute type]
expected: FAIL
[HTMLInputElement interface: createInput("tel") must inherit property "useMap" with the proper type]
expected: FAIL

4
tests/wpt/meta-legacy-layout/html/semantics/forms/the-fieldset-element/HTMLFieldSetElement.html.ini vendored
View file

@ -1,8 +1,4 @@
[HTMLFieldSetElement.html]
type: testharness
[The type attribute must return 'fieldset']
expected: FAIL
[The elements must return an HTMLFormControlsCollection object]
expected: FAIL

3
tests/wpt/meta/html/dom/idlharness.https.html.ini vendored
View file

@ -2823,9 +2823,6 @@
[HTMLEmbedElement interface: document.createElement("embed") must inherit property "name" with the proper type]
expected: FAIL
[HTMLFieldSetElement interface: attribute type]
expected: FAIL
[HTMLInputElement interface: createInput("tel") must inherit property "useMap" with the proper type]
expected: FAIL

3
tests/wpt/meta/html/semantics/forms/the-fieldset-element/HTMLFieldSetElement.html.ini vendored
View file

@ -1,3 +0,0 @@
[HTMLFieldSetElement.html]
[The type attribute must return 'fieldset']
expected: FAIL