From ed9cf6b4eb037fc22b15a531ad554a92b75b8f37 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Emilio=20Cobos=20=C3=81lvarez?= <emilio@crisal.io>
Date: Tue, 31 Oct 2017 20:20:55 +0100
Subject: [PATCH] style: Avoid double-applying text-zoom for keywords.

Bug: 1412743
Reviewed-by: Manishearth
---
 components/style/properties/longhand/font.mako.rs | 12 +++++-------
 components/style/values/computed/font.rs          |  7 +++++++
 components/style/values/specified/font.rs         |  2 +-
 3 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/components/style/properties/longhand/font.mako.rs b/components/style/properties/longhand/font.mako.rs
index 566bf0f3a25..290df5d49aa 100644
--- a/components/style/properties/longhand/font.mako.rs
+++ b/components/style/properties/longhand/font.mako.rs
@@ -852,8 +852,7 @@ ${helpers.single_keyword_system("font-variant-caps",
                context.builder.get_font().gecko().mGenericID !=
                context.builder.get_parent_font().gecko().mGenericID {
                 if let Some(info) = computed.keyword_info {
-                    computed.size = context.maybe_zoom_text(info.kw.to_computed_value(context)
-                                                                .scale_by(info.factor) + info.offset)
+                    computed.size = info.to_computed_value(context);
                 }
             }
         % endif
@@ -885,8 +884,7 @@ ${helpers.single_keyword_system("font-variant-caps",
         let kw_inherited_size = context.builder.get_parent_font()
                                        .clone_font_size()
                                        .keyword_info.map(|info| {
-            context.maybe_zoom_text(SpecifiedValue::Keyword(info)
-                  .to_computed_value(context).size)
+            SpecifiedValue::Keyword(info).to_computed_value(context).size
         });
         let mut font = context.builder.take_font();
         font.inherit_font_size_from(context.builder.get_parent_font(),
@@ -904,9 +902,9 @@ ${helpers.single_keyword_system("font-variant-caps",
     pub fn cascade_initial_font_size(context: &mut Context) {
         // font-size's default ("medium") does not always
         // compute to the same value and depends on the font
-        let mut computed = longhands::font_size::get_initial_specified_value()
-                                            .to_computed_value(context);
-        computed.size = context.maybe_zoom_text(computed.size);
+        let computed =
+            longhands::font_size::get_initial_specified_value()
+                .to_computed_value(context);
         context.builder.mutate_font().set_font_size(computed);
         % if product == "gecko":
             let device = context.builder.device;
diff --git a/components/style/values/computed/font.rs b/components/style/values/computed/font.rs
index 03427594331..906affb4666 100644
--- a/components/style/values/computed/font.rs
+++ b/components/style/values/computed/font.rs
@@ -38,6 +38,13 @@ pub struct KeywordInfo {
 }
 
 impl KeywordInfo {
+    /// Computes the final size for this font-size keyword, accounting for
+    /// text-zoom.
+    pub fn to_computed_value(&self, context: &Context) -> NonNegativeLength {
+        let base = context.maybe_zoom_text(self.kw.to_computed_value(context));
+        base.scale_by(self.factor) + context.maybe_zoom_text(self.offset)
+    }
+
     /// Given a parent keyword info (self), apply an additional factor/offset to it
     pub fn compose(self, factor: f32, offset: NonNegativeLength) -> Self {
         KeywordInfo {
diff --git a/components/style/values/specified/font.rs b/components/style/values/specified/font.rs
index e4d007fcafa..e20d429b810 100644
--- a/components/style/values/specified/font.rs
+++ b/components/style/values/specified/font.rs
@@ -316,7 +316,7 @@ impl FontSize {
             FontSize::Keyword(i) => {
                 // As a specified keyword, this is keyword derived
                 info = Some(i);
-                context.maybe_zoom_text(i.kw.to_computed_value(context).scale_by(i.factor) + i.offset)
+                i.to_computed_value(context)
             }
             FontSize::Smaller => {
                 info = compose_keyword(1. / LARGER_FONT_SIZE_RATIO);