Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-29 16:19:14 +01:00
Code Issues Projects Releases Packages Wiki Activity

script: abort planned form navigations (#38676)

Browse source 
Servo shows a behavior unlike FF and Safari(I don't have Chrome), where
stopping a window does not cancel planned form navigation, resulting in
an infinite navigation loop. The current behavior of Servo does seem to
follow the wording of the spec, so I will open a [companion issue at the
spec](https://github.com/whatwg/html/issues/11562), and I have also
written a WPT tests for the non-standard but widely followed behavior.
This PR also adds a beginning of an implementation of the "ongoing
navigation" concept, which is used by the spec to cancel navigations,
and which is used in this PR only to cancel planned form navigations.
The generation id concept, which corresponds to the planned navigation
concept in the spec, is turned into a simple struct private cell, and is
documented per the spec.

Testing: A new WPT test is added
Fixes: Only one part of https://github.com/servo/servo/issues/36747

---------

Signed-off-by: gterzian <2792687+gterzian@users.noreply.github.com>
Signed-off-by: Gregory Terzian <2792687+gterzian@users.noreply.github.com>
Co-authored-by: Martin Robinson <mrobinson@igalia.com>
This commit is contained in:
Gregory Terzian 2025-08-22 13:02:53 +08:00 • committed by GitHub
parent 0026213799
commit ede9db2e18
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 144 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

7
tests/wpt/meta/MANIFEST.json vendored
View file

@ -698765,6 +698765,13 @@
{}
]
],
"form-submit-and-window-stop.html": [
"b1659d0d2686e8c538f4286b7f88d851ea532f09",
[
null,
{}
]
],
"grandparent_location_aboutsrcdoc.sub.window.js": [
"c182c29cfc7d7562de13257c74ff3e8085d110a9",
[

29
tests/wpt/tests/html/browsers/browsing-the-web/navigating-across-documents/form-submit-and-window-stop.html vendored Normal file
View file

@ -0,0 +1,29 @@
<!DOCTYPE html>
<meta charset="utf-8">
<title>The planned navigation of a form should be cancelled by a window stop
in the same task as the form submission</title>
<link rel="help" href="https://github.com/whatwg/html/issues/3730">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="resources/helpers.js"></script>
<body>
<script>
"use strict";
async_test(t => {
let unloaded = false;
window.onload = t.step_func(() => {
form.submit();
window.stop();
});
window.onunload = () => {
unloaded = true;
};
t.step_timeout(() => {
// The document should not have unloaded.
assert_equals(unloaded, false);
t.done();
}, 100);
});
</script>
<form id="form">