mirror of
https://github.com/servo/servo.git
synced 2025-08-05 05:30:08 +01:00
script: Lazy init and reuse const BOOLEAN_ATTRIBUTES
(#38423)
Follow up of #38401. - The constant String array was recreated for every invocation. Chromium store this as a global const. https://source.chromium.org/chromium/chromium/src/+/main:chrome/test/chromedriver/element_commands.cc;l=48-94?q=chrome%2Ftest%2Fchromedriver%2Felement_commands.cc We now use static `LazyLock` to lazy init and avoid recreation. - Clean up some comments Testing: Just refactor. --------- Signed-off-by: Euclid Ye <euclid.ye@huawei.com>
This commit is contained in:
parent
a27715a5a8
commit
ee1bfa61ce
2 changed files with 39 additions and 35 deletions
|
@ -1584,7 +1584,6 @@ pub(crate) fn handle_get_attribute(
|
|||
.send(
|
||||
get_known_element(documents, pipeline, node_id).map(|element| {
|
||||
if is_boolean_attribute(&name) {
|
||||
// element.get_attribute_by_name(DOMString::from(name)).map(|_| String::from("true"))
|
||||
if element.HasAttribute(DOMString::from(name)) {
|
||||
Some(String::from("true"))
|
||||
} else {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue