Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 05:30:08 +01:00
Code Issues Projects Releases Packages Wiki Activity

script: Lazy init and reuse const BOOLEAN_ATTRIBUTES (#38423)

Browse source 
Follow up of  #38401.
- The constant String array was recreated for every invocation. Chromium
store this as a global const.
https://source.chromium.org/chromium/chromium/src/+/main:chrome/test/chromedriver/element_commands.cc;l=48-94?q=chrome%2Ftest%2Fchromedriver%2Felement_commands.cc
We now use static `LazyLock` to lazy init and avoid recreation.
- Clean up some comments

Testing: Just refactor.

---------

Signed-off-by: Euclid Ye <euclid.ye@huawei.com>
This commit is contained in:
Euclid Ye 2025-08-02 10:45:52 +08:00 • committed by GitHub
parent a27715a5a8
commit ee1bfa61ce
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 39 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

73
components/script/dom/attr.rs
View file

@ -5,6 +5,7 @@
use std::borrow::ToOwned; use std::borrow::ToOwned;
use std::cell::LazyCell; use std::cell::LazyCell;
use std::mem; use std::mem;
use std::sync::LazyLock;
use devtools_traits::AttrInfo; use devtools_traits::AttrInfo;
use dom_struct::dom_struct; use dom_struct::dom_struct;
@ -298,38 +299,42 @@ pub(crate) fn is_boolean_attribute(name: &str) -> bool {
// webdriver/tests/classic/get_element_attribute/get.py // webdriver/tests/classic/get_element_attribute/get.py
// //
// [1] <https://html.spec.whatwg.org/multipage/#attributes-3> // [1] <https://html.spec.whatwg.org/multipage/#attributes-3>
[ static BOOLEAN_ATTRIBUTES: LazyLock<[&str; 30]> = LazyLock::new(|| {
"allowfullscreen", [
"alpha", "allowfullscreen",
"async", "alpha",
"autofocus", "async",
"autoplay", "autofocus",
"checked", "autoplay",
"controls", "checked",
"default", "controls",
"defer", "default",
"disabled", "defer",
"formnovalidate", "disabled",
"hidden", "formnovalidate",
"inert", "hidden",
"ismap", "inert",
"itemscope", "ismap",
"loop", "itemscope",
"multiple", "loop",
"muted", "multiple",
"nomodule", "muted",
"novalidate", "nomodule",
"open", "novalidate",
"playsinline", "open",
"readonly", "playsinline",
"required", "readonly",
"reversed", "required",
"selected", "reversed",
"shadowrootclonable", "selected",
"shadowrootcustomelementregistry", "shadowrootclonable",
"shadowrootdelegatesfocus", "shadowrootcustomelementregistry",
"shadowrootserializable", "shadowrootdelegatesfocus",
] "shadowrootserializable",
.iter() ]
.any(|&boolean_attr| boolean_attr.eq_ignore_ascii_case(name)) });
BOOLEAN_ATTRIBUTES
.iter()
.any(|&boolean_attr| boolean_attr.eq_ignore_ascii_case(name))
} }

1
components/script/webdriver_handlers.rs
View file

@ -1584,7 +1584,6 @@ pub(crate) fn handle_get_attribute(
.send( .send(
get_known_element(documents, pipeline, node_id).map(|element| { get_known_element(documents, pipeline, node_id).map(|element| {
if is_boolean_attribute(&name) { if is_boolean_attribute(&name) {
// element.get_attribute_by_name(DOMString::from(name)).map(|_| String::from("true"))
if element.HasAttribute(DOMString::from(name)) { if element.HasAttribute(DOMString::from(name)) {
Some(String::from("true")) Some(String::from("true"))
} else { } else {