mirror of
https://github.com/servo/servo.git
synced 2025-08-03 12:40:06 +01:00
Auto merge of #17686 - paulrouget:rm_Title, r=jdm
remove the ability to request for the title If we offer the ability to request info like these, we need to expose a lot of other getters, like url, loading state, favicon, … It's up to the embedder to keep track of the state of a browser. So let's keep that consistent. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17686) <!-- Reviewable:end -->
This commit is contained in:
commit
ee47fe1925
7 changed files with 5 additions and 59 deletions
|
@ -463,7 +463,6 @@ impl<Window: WindowMethods> IOCompositor<Window> {
|
|||
ShutdownState::NotShuttingDown) => {
|
||||
self.set_frame_tree(&frame_tree);
|
||||
self.send_viewport_rects();
|
||||
self.title_for_main_frame();
|
||||
}
|
||||
|
||||
(Msg::ScrollFragmentPoint(scroll_root_id, point, _),
|
||||
|
@ -1659,17 +1658,6 @@ impl<Window: WindowMethods> IOCompositor<Window> {
|
|||
// TODO(gw): Access via WR.
|
||||
1.0
|
||||
}
|
||||
|
||||
pub fn title_for_main_frame(&self) {
|
||||
let root_pipeline_id = match self.root_pipeline {
|
||||
None => return,
|
||||
Some(ref root_pipeline) => root_pipeline.id,
|
||||
};
|
||||
let msg = ConstellationMsg::GetPipelineTitle(root_pipeline_id);
|
||||
if let Err(e) = self.constellation_chan.send(msg) {
|
||||
warn!("Failed to send pipeline title ({}).", e);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue