From eefb0773a053422ecd5c7a5b0deaf1558f53ef22 Mon Sep 17 00:00:00 2001 From: Ms2ger Date: Thu, 2 Apr 2015 17:55:57 +0200 Subject: [PATCH] Remove the unsafe impl Send for ConstellationControlMsg. This impl made it possible to put raw pointers in ConstellationControlMsg and send them across threads without considering the consequences. This required making SmallVec1 Send if T is Send. --- components/script_traits/lib.rs | 3 --- components/servo/Cargo.lock | 2 +- ports/cef/Cargo.lock | 2 +- ports/gonk/Cargo.lock | 2 +- 4 files changed, 3 insertions(+), 6 deletions(-) diff --git a/components/script_traits/lib.rs b/components/script_traits/lib.rs index 626819ebea6..97131a8bb90 100644 --- a/components/script_traits/lib.rs +++ b/components/script_traits/lib.rs @@ -76,9 +76,6 @@ pub enum ConstellationControlMsg { UpdateSubpageId(PipelineId, SubpageId, SubpageId), } -unsafe impl Send for ConstellationControlMsg { -} - /// The mouse button involved in the event. #[derive(Clone, Debug)] pub enum MouseButton { diff --git a/components/servo/Cargo.lock b/components/servo/Cargo.lock index 862b17b01df..7bad5e11a28 100644 --- a/components/servo/Cargo.lock +++ b/components/servo/Cargo.lock @@ -816,7 +816,7 @@ dependencies = [ [[package]] name = "selectors" version = "0.1.0" -source = "git+https://github.com/servo/rust-selectors#f3cffb2c37cf1a4dac06a02eb00a882626039a0c" +source = "git+https://github.com/servo/rust-selectors#12d3ce84a12ded4cf1def63651ccab06e1cfa80e" dependencies = [ "bitflags 0.1.1 (registry+https://github.com/rust-lang/crates.io-index)", "cssparser 0.2.0 (git+https://github.com/servo/rust-cssparser)", diff --git a/ports/cef/Cargo.lock b/ports/cef/Cargo.lock index f182a770fe7..44a2d9a84ac 100644 --- a/ports/cef/Cargo.lock +++ b/ports/cef/Cargo.lock @@ -822,7 +822,7 @@ dependencies = [ [[package]] name = "selectors" version = "0.1.0" -source = "git+https://github.com/servo/rust-selectors#f3cffb2c37cf1a4dac06a02eb00a882626039a0c" +source = "git+https://github.com/servo/rust-selectors#12d3ce84a12ded4cf1def63651ccab06e1cfa80e" dependencies = [ "bitflags 0.1.1 (registry+https://github.com/rust-lang/crates.io-index)", "cssparser 0.2.0 (git+https://github.com/servo/rust-cssparser)", diff --git a/ports/gonk/Cargo.lock b/ports/gonk/Cargo.lock index a249d547732..8fad18d177c 100644 --- a/ports/gonk/Cargo.lock +++ b/ports/gonk/Cargo.lock @@ -746,7 +746,7 @@ dependencies = [ [[package]] name = "selectors" version = "0.1.0" -source = "git+https://github.com/servo/rust-selectors#f3cffb2c37cf1a4dac06a02eb00a882626039a0c" +source = "git+https://github.com/servo/rust-selectors#12d3ce84a12ded4cf1def63651ccab06e1cfa80e" dependencies = [ "bitflags 0.1.1 (registry+https://github.com/rust-lang/crates.io-index)", "cssparser 0.2.0 (git+https://github.com/servo/rust-cssparser)",