From ef5ded943cec8cd299c67095755a71833bfda56a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fernando=20Jim=C3=A9nez=20Moreno?= <ferjmoreno@gmail.com>
Date: Tue, 18 Jun 2019 14:59:30 +0200
Subject: [PATCH] Remove event listeners if controls are removed

---
 resources/media-controls.js | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/resources/media-controls.js b/resources/media-controls.js
index bfb0fb5edf0..323fa73316d 100644
--- a/resources/media-controls.js
+++ b/resources/media-controls.js
@@ -80,11 +80,9 @@
       // Get the instance of the host of these controls.
       this.media = this.controls.host;
 
-      this.shutthingDown = false;
       this.mutationObserver = new MutationObserver(() => {
         // We can only get here if the `controls` attribute is removed.
-        this.shutthingDown = true;
-        this.mutationObserver.disconnect();
+        this.cleanup();
       });
       this.mutationObserver.observe(this.media, {
         attributeFilter: ["controls"]
@@ -208,15 +206,22 @@
       this.onStateChange(null);
     }
 
+    cleanup() {
+      this.mutationObserver.disconnect();
+      this.mediaEvents.forEach(event => {
+        this.media.removeEventListener(event, this);
+      });
+      this.controlEvents.forEach(({ el, type }) => {
+        el.removeEventListener(type, this);
+      });
+    }
+
     // State change handler
     onStateChange(from) {
       this.render(from);
     }
 
     render(from = this.state) {
-      if (this.shutthingDown) {
-        return;
-      }
       const isAudioOnly = this.media.localName == "audio";
       if (!isAudioOnly) {
         // XXX This should ideally use clientHeight/clientWidth,