mirror of
https://github.com/servo/servo.git
synced 2025-08-11 08:25:32 +01:00
Auto merge of #16861 - gterzian:use_microtask_to_await_stable_state, r=jdm
Use microtasks to await a stable state. <!-- Please describe your changes on the following line: --> @jdm @KiChjang First pass at using microtasks to await a stable state. I ran into all sorts of problems to get it to compile, I think it's mainly related to the fact that the microtasks are stored in a `Vec`, which meant the `Runnalbe.handler(self: Box<Self>)` couldn't be called while iterating over the Vec... It compiles now although I haven't run any tests. I'm assuming I'm missing something fundamental and was hoping my changes would highlight the problems I run into, and you had a better idea of how to implement this... Perhaps we shouldn't pass a `Runnable` to `await_stable_state` at all? --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #15375 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16861) <!-- Reviewable:end -->
This commit is contained in:
commit
f05491166f
12 changed files with 47 additions and 97 deletions
|
@ -1,5 +0,0 @@
|
|||
[resource-selection-invoke-in-sync-event.html]
|
||||
type: testharness
|
||||
[await a stable state and sync event handlers]
|
||||
expected: FAIL
|
||||
|
|
@ -1,5 +0,0 @@
|
|||
[resource-selection-invoke-load.html]
|
||||
type: testharness
|
||||
[invoking resource selection with load()]
|
||||
expected: FAIL
|
||||
|
|
@ -1,5 +0,0 @@
|
|||
[resource-selection-invoke-pause-networkState.html]
|
||||
type: testharness
|
||||
[NOT invoking resource selection with pause() when networkState is not NETWORK_EMPTY]
|
||||
expected: FAIL
|
||||
|
|
@ -1,5 +0,0 @@
|
|||
[resource-selection-invoke-pause.html]
|
||||
type: testharness
|
||||
[invoking resource selection with pause()]
|
||||
expected: FAIL
|
||||
|
|
@ -1,5 +0,0 @@
|
|||
[resource-selection-invoke-play.html]
|
||||
type: testharness
|
||||
[invoking resource selection with play()]
|
||||
expected: FAIL
|
||||
|
|
@ -1,5 +0,0 @@
|
|||
[resource-selection-invoke-remove-from-document-networkState.html]
|
||||
type: testharness
|
||||
[NOT invoking resource selection with implicit pause() when networkState is not NETWORK_EMPTY]
|
||||
expected: FAIL
|
||||
|
|
@ -1,5 +0,0 @@
|
|||
[resource-selection-invoke-set-src-not-in-document.html]
|
||||
type: testharness
|
||||
[invoking load by setting src on video not in a document]
|
||||
expected: FAIL
|
||||
|
|
@ -1,5 +0,0 @@
|
|||
[resource-selection-invoke-set-src.html]
|
||||
type: testharness
|
||||
[invoking load by setting src]
|
||||
expected: FAIL
|
||||
|
|
@ -1,5 +0,0 @@
|
|||
[resource-selection-remove-src.html]
|
||||
type: testharness
|
||||
[invoking resource selection by setting src; await stable state]
|
||||
expected: FAIL
|
||||
|
Loading…
Add table
Add a link
Reference in a new issue