Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 21:50:18 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #8505 - frewsxcv:html-table-cell-element-bgcolor-idl-attribute, r=Ms2ger

Browse source 
Implement 'bgcolor' IDL attribute for 'HTMLTableCellElement'

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8505)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2015-11-13 15:07:53 +05:30
commit f078f8fdf4
4 changed files with 7 additions and 268 deletions
Download patch file Download diff file Expand all files Collapse all files

6
components/script/dom/htmltablecellelement.rs
View file

@ -50,6 +50,12 @@ impl HTMLTableCellElementMethods for HTMLTableCellElement {
// https://html.spec.whatwg.org/multipage/#dom-tdth-colspan
make_uint_setter!(SetColSpan, "colspan", DEFAULT_COLSPAN);
// https://html.spec.whatwg.org/multipage/#dom-tdth-bgcolor
make_getter!(BgColor);
// https://html.spec.whatwg.org/multipage/#dom-tdth-bgcolor
make_legacy_color_setter!(SetBgColor, "bgcolor");
// https://html.spec.whatwg.org/multipage/#dom-tdth-cellindex
fn CellIndex(&self) -> i32 {
let self_node = self.upcast::<Node>();

2
components/script/dom/webidls/HTMLTableCellElement.webidl
View file

@ -26,5 +26,5 @@ partial interface HTMLTableCellElement {
// attribute boolean noWrap;
// attribute DOMString vAlign;
//[TreatNullAs=EmptyString] attribute DOMString bgColor;
[TreatNullAs=EmptyString] attribute DOMString bgColor;
};

9
tests/wpt/metadata/html/dom/interfaces.html.ini
View file

@ -4713,9 +4713,6 @@
[HTMLTableCellElement interface: document.createElement("td") must inherit property "vAlign" with the proper type (11)]
expected: FAIL
[HTMLTableCellElement interface: document.createElement("td") must inherit property "bgColor" with the proper type (12)]
expected: FAIL
[HTMLTableHeaderCellElement interface: existence and properties of interface object]
expected: FAIL
@ -4773,9 +4770,6 @@
[HTMLTableCellElement interface: document.createElement("th") must inherit property "vAlign" with the proper type (11)]
expected: FAIL
[HTMLTableCellElement interface: document.createElement("th") must inherit property "bgColor" with the proper type (12)]
expected: FAIL
[HTMLTableCellElement interface: existence and properties of interface object]
expected: FAIL
@ -4809,9 +4803,6 @@
[HTMLTableCellElement interface: attribute vAlign]
expected: FAIL
[HTMLTableCellElement interface: attribute bgColor]
expected: FAIL
[HTMLFormElement interface: existence and properties of interface object]
expected: FAIL

258
tests/wpt/metadata/html/dom/reflection-tabular.html.ini
View file

@ -12345,135 +12345,6 @@
[td.vAlign: IDL set to object "test-valueOf" followed by IDL get]
expected: FAIL
[td.bgColor: typeof IDL attribute]
expected: FAIL
[td.bgColor: IDL get with DOM attribute unset]
expected: FAIL
[td.bgColor: setAttribute() to "" followed by IDL get]
expected: FAIL
[td.bgColor: setAttribute() to " \\0\\x01\\x02\\x03\\x04\\x05\\x06\\x07 \\b\\t\\n\\v\\f\\r\\x0e\\x0f \\x10\\x11\\x12\\x13\\x14\\x15\\x16\\x17 \\x18\\x19\\x1a\\x1b\\x1c\\x1d\\x1e\\x1f foo " followed by IDL get]
expected: FAIL
[td.bgColor: setAttribute() to undefined followed by IDL get]
expected: FAIL
[td.bgColor: setAttribute() to 7 followed by IDL get]
expected: FAIL
[td.bgColor: setAttribute() to 1.5 followed by IDL get]
expected: FAIL
[td.bgColor: setAttribute() to true followed by IDL get]
expected: FAIL
[td.bgColor: setAttribute() to false followed by IDL get]
expected: FAIL
[td.bgColor: setAttribute() to object "[object Object\]" followed by IDL get]
expected: FAIL
[td.bgColor: setAttribute() to NaN followed by IDL get]
expected: FAIL
[td.bgColor: setAttribute() to Infinity followed by IDL get]
expected: FAIL
[td.bgColor: setAttribute() to -Infinity followed by IDL get]
expected: FAIL
[td.bgColor: setAttribute() to "\\0" followed by IDL get]
expected: FAIL
[td.bgColor: setAttribute() to null followed by IDL get]
expected: FAIL
[td.bgColor: setAttribute() to object "test-toString" followed by IDL get]
expected: FAIL
[td.bgColor: setAttribute() to object "test-valueOf" followed by IDL get]
expected: FAIL
[td.bgColor: IDL set to "" followed by getAttribute()]
expected: FAIL
[td.bgColor: IDL set to " \\0\\x01\\x02\\x03\\x04\\x05\\x06\\x07 \\b\\t\\n\\v\\f\\r\\x0e\\x0f \\x10\\x11\\x12\\x13\\x14\\x15\\x16\\x17 \\x18\\x19\\x1a\\x1b\\x1c\\x1d\\x1e\\x1f foo " followed by getAttribute()]
expected: FAIL
[td.bgColor: IDL set to undefined followed by getAttribute()]
expected: FAIL
[td.bgColor: IDL set to undefined followed by IDL get]
expected: FAIL
[td.bgColor: IDL set to 7 followed by getAttribute()]
expected: FAIL
[td.bgColor: IDL set to 7 followed by IDL get]
expected: FAIL
[td.bgColor: IDL set to 1.5 followed by getAttribute()]
expected: FAIL
[td.bgColor: IDL set to 1.5 followed by IDL get]
expected: FAIL
[td.bgColor: IDL set to true followed by getAttribute()]
expected: FAIL
[td.bgColor: IDL set to true followed by IDL get]
expected: FAIL
[td.bgColor: IDL set to false followed by getAttribute()]
expected: FAIL
[td.bgColor: IDL set to false followed by IDL get]
expected: FAIL
[td.bgColor: IDL set to object "[object Object\]" followed by getAttribute()]
expected: FAIL
[td.bgColor: IDL set to object "[object Object\]" followed by IDL get]
expected: FAIL
[td.bgColor: IDL set to NaN followed by getAttribute()]
expected: FAIL
[td.bgColor: IDL set to NaN followed by IDL get]
expected: FAIL
[td.bgColor: IDL set to Infinity followed by getAttribute()]
expected: FAIL
[td.bgColor: IDL set to Infinity followed by IDL get]
expected: FAIL
[td.bgColor: IDL set to -Infinity followed by getAttribute()]
expected: FAIL
[td.bgColor: IDL set to -Infinity followed by IDL get]
expected: FAIL
[td.bgColor: IDL set to "\\0" followed by getAttribute()]
expected: FAIL
[td.bgColor: IDL set to null followed by getAttribute()]
expected: FAIL
[td.bgColor: IDL set to null followed by IDL get]
expected: FAIL
[td.bgColor: IDL set to object "test-toString" followed by getAttribute()]
expected: FAIL
[td.bgColor: IDL set to object "test-toString" followed by IDL get]
expected: FAIL
[td.bgColor: IDL set to object "test-valueOf" followed by IDL get]
expected: FAIL
[td.abbr: typeof IDL attribute]
expected: FAIL
@ -14529,135 +14400,6 @@
[th.vAlign: IDL set to object "test-valueOf" followed by IDL get]
expected: FAIL
[th.bgColor: typeof IDL attribute]
expected: FAIL
[th.bgColor: IDL get with DOM attribute unset]
expected: FAIL
[th.bgColor: setAttribute() to "" followed by IDL get]
expected: FAIL
[th.bgColor: setAttribute() to " \\0\\x01\\x02\\x03\\x04\\x05\\x06\\x07 \\b\\t\\n\\v\\f\\r\\x0e\\x0f \\x10\\x11\\x12\\x13\\x14\\x15\\x16\\x17 \\x18\\x19\\x1a\\x1b\\x1c\\x1d\\x1e\\x1f foo " followed by IDL get]
expected: FAIL
[th.bgColor: setAttribute() to undefined followed by IDL get]
expected: FAIL
[th.bgColor: setAttribute() to 7 followed by IDL get]
expected: FAIL
[th.bgColor: setAttribute() to 1.5 followed by IDL get]
expected: FAIL
[th.bgColor: setAttribute() to true followed by IDL get]
expected: FAIL
[th.bgColor: setAttribute() to false followed by IDL get]
expected: FAIL
[th.bgColor: setAttribute() to object "[object Object\]" followed by IDL get]
expected: FAIL
[th.bgColor: setAttribute() to NaN followed by IDL get]
expected: FAIL
[th.bgColor: setAttribute() to Infinity followed by IDL get]
expected: FAIL
[th.bgColor: setAttribute() to -Infinity followed by IDL get]
expected: FAIL
[th.bgColor: setAttribute() to "\\0" followed by IDL get]
expected: FAIL
[th.bgColor: setAttribute() to null followed by IDL get]
expected: FAIL
[th.bgColor: setAttribute() to object "test-toString" followed by IDL get]
expected: FAIL
[th.bgColor: setAttribute() to object "test-valueOf" followed by IDL get]
expected: FAIL
[th.bgColor: IDL set to "" followed by getAttribute()]
expected: FAIL
[th.bgColor: IDL set to " \\0\\x01\\x02\\x03\\x04\\x05\\x06\\x07 \\b\\t\\n\\v\\f\\r\\x0e\\x0f \\x10\\x11\\x12\\x13\\x14\\x15\\x16\\x17 \\x18\\x19\\x1a\\x1b\\x1c\\x1d\\x1e\\x1f foo " followed by getAttribute()]
expected: FAIL
[th.bgColor: IDL set to undefined followed by getAttribute()]
expected: FAIL
[th.bgColor: IDL set to undefined followed by IDL get]
expected: FAIL
[th.bgColor: IDL set to 7 followed by getAttribute()]
expected: FAIL
[th.bgColor: IDL set to 7 followed by IDL get]
expected: FAIL
[th.bgColor: IDL set to 1.5 followed by getAttribute()]
expected: FAIL
[th.bgColor: IDL set to 1.5 followed by IDL get]
expected: FAIL
[th.bgColor: IDL set to true followed by getAttribute()]
expected: FAIL
[th.bgColor: IDL set to true followed by IDL get]
expected: FAIL
[th.bgColor: IDL set to false followed by getAttribute()]
expected: FAIL
[th.bgColor: IDL set to false followed by IDL get]
expected: FAIL
[th.bgColor: IDL set to object "[object Object\]" followed by getAttribute()]
expected: FAIL
[th.bgColor: IDL set to object "[object Object\]" followed by IDL get]
expected: FAIL
[th.bgColor: IDL set to NaN followed by getAttribute()]
expected: FAIL
[th.bgColor: IDL set to NaN followed by IDL get]
expected: FAIL
[th.bgColor: IDL set to Infinity followed by getAttribute()]
expected: FAIL
[th.bgColor: IDL set to Infinity followed by IDL get]
expected: FAIL
[th.bgColor: IDL set to -Infinity followed by getAttribute()]
expected: FAIL
[th.bgColor: IDL set to -Infinity followed by IDL get]
expected: FAIL
[th.bgColor: IDL set to "\\0" followed by getAttribute()]
expected: FAIL
[th.bgColor: IDL set to null followed by getAttribute()]
expected: FAIL
[th.bgColor: IDL set to null followed by IDL get]
expected: FAIL
[th.bgColor: IDL set to object "test-toString" followed by getAttribute()]
expected: FAIL
[th.bgColor: IDL set to object "test-toString" followed by IDL get]
expected: FAIL
[th.bgColor: IDL set to object "test-valueOf" followed by IDL get]
expected: FAIL
[th.scope: typeof IDL attribute]
expected: FAIL