Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-12 02:14:41 +00:00
Code Issues Projects Releases Packages Wiki Activity

Add lint for [ instead of [[ in shells scripts

Browse source
This commit is contained in:
Aneesh Agrawal 2016-08-05 09:42:04 -04:00
parent 9231ca1c69
commit f07d8f188a
5 changed files with 17 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

3
python/tidy/servo_tidy/tidy.py
View file

@ -347,6 +347,9 @@ def check_shell(file_name, lines):
if "`" in stripped:
yield (idx + 1, "script should not use backticks for command substitution")
if " [ " in stripped or stripped.startswith("[ "):
yield (idx + 1, "script should use `[[` instead of `[` for conditional testing")
for dollar in re.finditer('\$', stripped):
next_idx = dollar.end()
if next_idx < len(stripped):