From f0a178b56a7bccba103c0b96e95e687eb2188b5d Mon Sep 17 00:00:00 2001 From: Jonathan Kew Date: Sun, 21 May 2023 23:36:30 +0200 Subject: [PATCH] style: Un-prefix -moz-tab-size (keeping the prefixed version as an alias for now) This results in lots of new WPT test passes. There were also a couple of WPT tests that turned out to be broken; tab-size-inline-001 and -002 had errors in their reference files such that they'd never pass anywhere. So those are fixed here. Depends on D117331 Differential Revision: https://phabricator.services.mozilla.com/D117332 --- components/style/properties/counted_unknown_properties.py | 1 - components/style/properties/data.py | 2 +- components/style/properties/longhands/inherited_text.mako.rs | 3 ++- components/style/values/generics/length.rs | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/components/style/properties/counted_unknown_properties.py b/components/style/properties/counted_unknown_properties.py index 56d647cb57d..2548e591060 100644 --- a/components/style/properties/counted_unknown_properties.py +++ b/components/style/properties/counted_unknown_properties.py @@ -25,7 +25,6 @@ COUNTED_UNKNOWN_PROPERTIES = [ "-webkit-user-modify", "-webkit-margin-before", "-webkit-margin-after", - "tab-size", "-webkit-margin-start", "-webkit-column-break-inside", "-webkit-padding-start", diff --git a/components/style/properties/data.py b/components/style/properties/data.py index 8a523ccb66f..8f3c7d35269 100644 --- a/components/style/properties/data.py +++ b/components/style/properties/data.py @@ -759,7 +759,7 @@ def _add_logical_props(data, props): # These are probably Gecko bugs and should be supported per spec. def _remove_common_first_line_and_first_letter_properties(props, engine): if engine == "gecko": - props.remove("-moz-tab-size") + props.remove("tab-size") props.remove("hyphens") props.remove("line-break") props.remove("text-align-last") diff --git a/components/style/properties/longhands/inherited_text.mako.rs b/components/style/properties/longhands/inherited_text.mako.rs index fc0e5d8fdea..3a66eee9a3f 100644 --- a/components/style/properties/longhands/inherited_text.mako.rs +++ b/components/style/properties/longhands/inherited_text.mako.rs @@ -238,12 +238,13 @@ ${helpers.predefined_type( )} ${helpers.predefined_type( - "-moz-tab-size", + "tab-size", "NonNegativeLengthOrNumber", "generics::length::LengthOrNumber::Number(From::from(8.0))", engines="gecko", animation_value_type="LengthOrNumber", spec="https://drafts.csswg.org/css-text-3/#tab-size-property", + aliases="-moz-tab-size", )} ${helpers.predefined_type( diff --git a/components/style/values/generics/length.rs b/components/style/values/generics/length.rs index 3885220efa5..dfb3504e3cf 100644 --- a/components/style/values/generics/length.rs +++ b/components/style/values/generics/length.rs @@ -235,7 +235,7 @@ impl MaxSize { } } -/// A generic `` | `` value for the `-moz-tab-size` property. +/// A generic `` | `` value for the `tab-size` property. #[derive( Animate, Clone,