Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-24 07:40:27 +01:00
Code Issues Projects Releases Packages Wiki Activity

Use util::str::str_join in more places

Browse source 
Instead of intermediate allocations of `Vec`s, we should utilize
`str_join` which operates on iterators
This commit is contained in:
Corey Farwell 2015-09-28 19:57:06 -04:00
parent 2857e547be
commit f14f09e886
4 changed files with 7 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

5
components/script/dom/htmloptionelement.rs
View file

@ -18,7 +18,7 @@ use dom::htmlelement::{HTMLElement, HTMLElementTypeId};
use dom::node::{Node, NodeTypeId};
use dom::virtualmethods::VirtualMethods;
use std::cell::Cell;
use util::str::{DOMString, split_html_space_chars};
use util::str::{DOMString, split_html_space_chars, str_join};
#[dom_struct]
pub struct HTMLOptionElement {
@ -93,8 +93,7 @@ impl HTMLOptionElementMethods for HTMLOptionElement {
let node = NodeCast::from_ref(self);
let mut content = String::new();
collect_text(&node, &mut content);
let v: Vec<&str> = split_html_space_chars(&content).collect();
v.join(" ")
str_join(split_html_space_chars(&content), " ")
}
// https://www.whatwg.org/html/#dom-option-text