Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 21:50:18 +01:00
Code Issues Projects Releases Packages Wiki Activity

style: fix invalidation of sibling combinators in different slots

Browse source 
This extends the code to deal with sibling invalidation to handle the
case where the flat tree doesn't match the DOM tree. In the test-case
for example, dom is:

  * details
    * summary id=a
    * summary

But flat tree is:

  * details
  * slot
    * summary id=a
  * slot
    * summary

Differential Revision: https://phabricator.services.mozilla.com/D159150
This commit is contained in:
Emilio Cobos Álvarez 2022-10-20 08:39:18 +00:00 • committed by Martin Robinson
parent 6cb665df95
commit f14f1fa440
6 changed files with 66 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

6
components/style/traversal.rs
View file

@ -157,6 +157,8 @@ pub trait DomTraversal<E: TElement>: Sync {
/// such, we have a pre-traversal step to handle that part and determine whether
/// a full traversal is needed.
fn pre_traverse(root: E, shared_context: &SharedStyleContext) -> PreTraverseToken<E> {
use crate::invalidation::element::state_and_attributes::propagate_dirty_bit_up_to;
let traversal_flags = shared_context.traversal_flags;
let mut data = root.mutate_data();
@ -174,11 +176,11 @@ pub trait DomTraversal<E: TElement>: Sync {
);
if invalidation_result.has_invalidated_siblings() {
let actual_root = root.traversal_parent().expect(
let actual_root = root.as_node().parent_element_or_host().expect(
"How in the world can you invalidate \
siblings without a parent?",
);
unsafe { actual_root.set_dirty_descendants() }
propagate_dirty_bit_up_to(actual_root, root);
return PreTraverseToken(Some(actual_root));
}
}