Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-12 17:05:33 +01:00
Code Issues Projects Releases Packages Wiki Activity

webdriver: Element click waits for navigation complete (#37935)

Browse source 
Step 11 in https://w3c.github.io/webdriver/#dfn-element-click

> [Try](https://w3c.github.io/webdriver/#dfn-try) to [wait for
navigation to
complete](https://w3c.github.io/webdriver/#dfn-wait-for-navigation-to-complete)
with session.

This fixes issue in which element_click triggers navigation, but
incoming commands still interact with old page.

Testing:
https://github.com/longvatrong111/servo/actions/runs/16175767947
https://github.com/longvatrong111/servo/actions/runs/16175770044

Signed-off-by: batu_hoang <longvatrong111@gmail.com>
This commit is contained in:
batu_hoang 2025-07-15 14:51:05 +08:00 • committed by GitHub
parent ff02fdad6d
commit f155c95e1b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 137 additions and 63 deletions
Download patch file Download diff file Expand all files Collapse all files

7
ports/servoshell/desktop/app_state.rs
View file

@ -470,6 +470,13 @@ impl RunningAppState {
});
}
}
pub(crate) fn remove_load_status_sender(&self, webview_id: WebViewId) {
self.webdriver_senders
.borrow_mut()
.load_status_senders
.remove(&webview_id);
}
}
struct ServoShellServoDelegate;