Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-19 11:20:09 +01:00
Code Issues Projects Releases Packages Wiki Activity

Add preference observer API for runtime webxr preference changes (#38649)

Browse source 
Adds a global preference observer that is notified whenever any
preference value is updated. This is used to support runtime
configuration of WebXR automated testing, which is a prerequisite for
running multiple WPT tests in a single browser session.

Testing: Ran `./mach test-wpt /webxr --product=servodriver`
Fixes: #38647

---------

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews 2025-08-16 04:49:13 -04:00 • committed by GitHub
parent fc3feceee5
commit f19b2f6e84
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 63 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

25
ports/servoshell/desktop/webxr.rs
View file

@ -4,9 +4,11 @@
use std::cell::RefCell;
use std::rc::Rc;
use std::sync::Arc;
use std::sync::atomic::{AtomicBool, Ordering};
use servo::config::pref;
use servo::config::prefs::Preferences;
use servo::config::prefs::{self, Preferences};
use servo::webxr::WebXrRegistry;
use servo::webxr::glwindow::GlWindowDiscovery;
#[cfg(target_os = "windows")]
@ -60,14 +62,29 @@ impl XrDiscoveryWebXrRegistry {
}
}
struct XrPrefObserver(Arc<AtomicBool>);
impl prefs::Observer for XrPrefObserver {
fn prefs_changed(&self, changes: Vec<(&'static str, prefs::PrefValue)>) {
if let Some((_, value)) = changes.iter().find(|(name, _)| *name == "dom_webxr_test") {
let prefs::PrefValue::Bool(value) = value else {
return;
};
self.0.store(*value, Ordering::Relaxed);
}
}
}
#[cfg(feature = "webxr")]
impl WebXrRegistry for XrDiscoveryWebXrRegistry {
fn register(&self, xr: &mut servo::webxr::MainThreadRegistry) {
use servo::webxr::headless::HeadlessMockDiscovery;
if pref!(dom_webxr_test) {
xr.register_mock(HeadlessMockDiscovery::default());
} else if let Some(xr_discovery) = self.xr_discovery.take() {
let mock_enabled = Arc::new(AtomicBool::new(pref!(dom_webxr_test)));
xr.register_mock(HeadlessMockDiscovery::new(mock_enabled.clone()));
prefs::set_observer(Box::new(XrPrefObserver(mock_enabled)));
if let Some(xr_discovery) = self.xr_discovery.take() {
match xr_discovery {
XrDiscovery::GlWindow(discovery) => xr.register(discovery),
#[cfg(target_os = "windows")]