Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-11 00:15:32 +01:00
Code Issues Projects Releases Packages Wiki Activity

Stop sending " " to linebreaker for replaced content (#30740)

Browse source 
We previously sent a " " to the linebreaker in order to ensure that the
next text had a soft wrap opportunity at the start. Calling `next(" ")`
without waiting until the returned index was 1, violated some
invariants of linebreaker ultimately causing a panic.

Instead of using the linebreaker for this, simply keep a flag in the
IFC layout state, which avoids the problem entirely.

Fixes #30703.
This commit is contained in:
Martin Robinson 2023-11-30 15:46:14 +01:00 • committed by GitHub
parent 53b0fa827d
commit f1c291853e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
8 changed files with 57 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

2
tests/wpt/meta/css/css-text/line-breaking/line-breaking-atomic-002.html.ini
View file

@ -1,2 +0,0 @@
[line-breaking-atomic-002.html]
expected: FAIL

2
tests/wpt/meta/css/css-text/line-breaking/line-breaking-atomic-009.html.ini
View file

@ -1,2 +0,0 @@
[line-breaking-atomic-009.html]
expected: FAIL

2
tests/wpt/meta/css/css-text/line-breaking/line-breaking-replaced-001.html.ini
View file

@ -1,2 +0,0 @@
[line-breaking-replaced-001.html]
expected: FAIL

2
tests/wpt/meta/css/css-text/line-breaking/line-breaking-replaced-006.html.ini
View file

@ -1,2 +0,0 @@
[line-breaking-replaced-006.html]
expected: FAIL