Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-30 00:29:14 +01:00
Code Issues Projects Releases Packages Wiki Activity

Don't register unconnected shadow roots with their owner document (#34361)

Browse source 
* Don't falsely register Shadow Roots as connected

Previously, a shadowroot would be registered as connected
during the shadow hosts bind_to_tree call, even if the host
was being bound to an element that was not itself
connected to a document.

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Update WPT expectations

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Move bind/unbind methods into a VirtualMethod impl

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Add DocumentFragment/Shadowroot to vtable_for

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

---------

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
This commit is contained in:
Simon Wülker 2024-12-02 19:33:25 +01:00 • committed by GitHub
parent 888a93af47
commit f1e89c58a6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
10 changed files with 161 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

1
tests/wpt/meta/custom-elements/CustomElementRegistry.html.ini vendored
View file

@ -1,5 +1,4 @@
[CustomElementRegistry.html]
expected: CRASH
[customElements.define must upgrade elements in the shadow-including tree order]
expected: FAIL

1
tests/wpt/meta/custom-elements/custom-element-registry/upgrade.html.ini vendored
View file

@ -1,4 +1,3 @@
[upgrade.html]
expected: CRASH
[Two elements as shadow-including descendants (and not descendants) of the upgraded node]
expected: FAIL