mirror of
https://github.com/servo/servo.git
synced 2025-08-05 13:40:08 +01:00
Refactor selection-start-end test
Move assertions about the initial value of selection{Start,End} to their own tests. This ensures that when one of these assertions fails, it doesn't prevent other tests from being defined. Thus we have a clearer view of which tests are passing or failing, since all tests get defined regardless of which assertions fail.
This commit is contained in:
parent
e61a4d04e9
commit
f290cacccd
3 changed files with 58 additions and 17 deletions
|
@ -542575,7 +542575,7 @@
|
||||||
"testharness"
|
"testharness"
|
||||||
],
|
],
|
||||||
"html/semantics/forms/textfieldselection/selection-start-end.html": [
|
"html/semantics/forms/textfieldselection/selection-start-end.html": [
|
||||||
"e38a79075e27780327f49e7ae9cadd2558165eac",
|
"3fd1c942f7ac3ed3097bbd1ec89db15fb0805476",
|
||||||
"testharness"
|
"testharness"
|
||||||
],
|
],
|
||||||
"html/semantics/forms/textfieldselection/selection-value-interactions.html": [
|
"html/semantics/forms/textfieldselection/selection-value-interactions.html": [
|
||||||
|
|
|
@ -1,11 +1,6 @@
|
||||||
[selection-start-end.html]
|
[selection-start-end.html]
|
||||||
type: testharness
|
type: testharness
|
||||||
[onselect should fire when selectionStart is changed]
|
expected: TIMEOUT
|
||||||
expected: FAIL
|
|
||||||
|
|
||||||
[onselect should fire when selectionEnd is changed]
|
|
||||||
expected: FAIL
|
|
||||||
|
|
||||||
[Setting selectionStart to a value larger than selectionEnd should increase selectionEnd]
|
[Setting selectionStart to a value larger than selectionEnd should increase selectionEnd]
|
||||||
expected: FAIL
|
expected: FAIL
|
||||||
|
|
||||||
|
@ -15,3 +10,51 @@
|
||||||
[selectionStart edge-case values]
|
[selectionStart edge-case values]
|
||||||
expected: FAIL
|
expected: FAIL
|
||||||
|
|
||||||
|
[Initial .value set on textarea-appended should set selectionStart to end of value]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Initial .value set on textarea-not-appended should set selectionStart to end of value]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Initial .value set on textarea-appended-prefocused should set selectionStart to end of value]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Initial .value set on textarea-not-appended-prefocused should set selectionStart to end of value]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[onselect should fire when selectionStart is changed on textarea-appended]
|
||||||
|
expected: NOTRUN
|
||||||
|
|
||||||
|
[onselect should fire when selectionStart is changed on textarea-not-appended]
|
||||||
|
expected: NOTRUN
|
||||||
|
|
||||||
|
[onselect should fire when selectionStart is changed on textarea-appended-prefocused]
|
||||||
|
expected: NOTRUN
|
||||||
|
|
||||||
|
[onselect should fire when selectionStart is changed on textarea-not-appended-prefocused]
|
||||||
|
expected: NOTRUN
|
||||||
|
|
||||||
|
[onselect should fire when selectionEnd is changed on textarea-appended]
|
||||||
|
expected: NOTRUN
|
||||||
|
|
||||||
|
[onselect should fire when selectionEnd is changed on textarea-not-appended]
|
||||||
|
expected: NOTRUN
|
||||||
|
|
||||||
|
[onselect should fire when selectionEnd is changed on textarea-appended-prefocused]
|
||||||
|
expected: NOTRUN
|
||||||
|
|
||||||
|
[onselect should fire when selectionEnd is changed on textarea-not-appended-prefocused]
|
||||||
|
expected: NOTRUN
|
||||||
|
|
||||||
|
[Initial .value set on textarea-appended should set selectionEnd to end of value]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Initial .value set on textarea-not-appended should set selectionEnd to end of value]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Initial .value set on textarea-appended-prefocused should set selectionEnd to end of value]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Initial .value set on textarea-not-appended-prefocused should set selectionEnd to end of value]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
|
|
@ -59,10 +59,16 @@
|
||||||
assert_equals(testValue.length, 10);
|
assert_equals(testValue.length, 10);
|
||||||
}, "Sanity check for testValue length; if this fails, variou absolute offsets in the test below need to be adjusted to be less than testValue.length");
|
}, "Sanity check for testValue length; if this fails, variou absolute offsets in the test below need to be adjusted to be less than testValue.length");
|
||||||
|
|
||||||
|
for (let prop of ["selectionStart", "selectionEnd"]) {
|
||||||
|
for (let el of createTestElements(testValue)) {
|
||||||
|
test(function() {
|
||||||
|
assert_equals(el.selectionStart, testValue.length);
|
||||||
|
}, `Initial .value set on ${el.id} should set ${prop} to end of value`);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
test(function() {
|
test(function() {
|
||||||
for (let el of createTestElements(testValue)) {
|
for (let el of createTestElements(testValue)) {
|
||||||
assert_equals(el.selectionStart, testValue.length,
|
|
||||||
`Initial .value set on ${el.id} should set selectionStart to end of value`);
|
|
||||||
var t = async_test(`onselect should fire when selectionStart is changed on ${el.id}`);
|
var t = async_test(`onselect should fire when selectionStart is changed on ${el.id}`);
|
||||||
el.onselect = t.step_func_done(function(e) {
|
el.onselect = t.step_func_done(function(e) {
|
||||||
assert_equals(e.type, "select");
|
assert_equals(e.type, "select");
|
||||||
|
@ -74,8 +80,6 @@
|
||||||
|
|
||||||
test(function() {
|
test(function() {
|
||||||
for (let el of createTestElements(testValue)) {
|
for (let el of createTestElements(testValue)) {
|
||||||
assert_equals(el.selectionEnd, testValue.length,
|
|
||||||
`Initial .value set on ${el.id} should set selectionEnd to end of value`);
|
|
||||||
var t = async_test(`onselect should fire when selectionEnd is changed on ${el.id}`);
|
var t = async_test(`onselect should fire when selectionEnd is changed on ${el.id}`);
|
||||||
el.onselect = t.step_func_done(function(e) {
|
el.onselect = t.step_func_done(function(e) {
|
||||||
assert_equals(e.type, "select");
|
assert_equals(e.type, "select");
|
||||||
|
@ -87,8 +91,6 @@
|
||||||
|
|
||||||
test(function() {
|
test(function() {
|
||||||
for (let el of createTestElements(testValue)) {
|
for (let el of createTestElements(testValue)) {
|
||||||
assert_equals(el.selectionStart, testValue.length,
|
|
||||||
`Initial .value set on ${el.id} should set selectionStart to end of value`);
|
|
||||||
el.selectionStart = 0;
|
el.selectionStart = 0;
|
||||||
el.selectionEnd = 5;
|
el.selectionEnd = 5;
|
||||||
el.selectionStart = 8;
|
el.selectionStart = 8;
|
||||||
|
@ -100,10 +102,6 @@
|
||||||
|
|
||||||
test(function() {
|
test(function() {
|
||||||
for (let el of createTestElements(testValue)) {
|
for (let el of createTestElements(testValue)) {
|
||||||
assert_equals(el.selectionStart, testValue.length,
|
|
||||||
`Initial .value set on ${el.id} should set selectionStart to end of value`);
|
|
||||||
assert_equals(el.selectionEnd, testValue.length,
|
|
||||||
`Initial .value set on ${el.id} should set selectionEnd to end of value`);
|
|
||||||
el.selectionStart = 8;
|
el.selectionStart = 8;
|
||||||
el.selectionEnd = 5;
|
el.selectionEnd = 5;
|
||||||
assert_equals(el.selectionStart, 5, `selectionStart on ${el.id}`);
|
assert_equals(el.selectionStart, 5, `selectionStart on ${el.id}`);
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue