Move the from_declaration to its only caller and remove the empty legacy module.

components/script/dom/element.rs

@@ -75,7 +75,6 @@ use std::default::Default;
 use std::mem;
 use std::sync::Arc;
 use string_cache::{Atom, Namespace, QualName};
-use style::legacy::from_declaration;
 use style::properties::DeclaredValue;
 use style::properties::longhands::{self, background_image, border_spacing, font_family, font_size};
 use style::properties::{PropertyDeclaration, PropertyDeclarationBlock, parse_style_attribute};
@@ -259,6 +258,12 @@ impl LayoutElementHelpers for LayoutJS<Element> {
     unsafe fn synthesize_presentational_hints_for_legacy_attributes<V>(&self, hints: &mut V)
         where V: VecLike<DeclarationBlock<Vec<PropertyDeclaration>>>
     {
+        #[inline]
+        fn from_declaration(rule: PropertyDeclaration)
+                            -> DeclarationBlock<Vec<PropertyDeclaration>> {
+            DeclarationBlock::from_declarations(Arc::new(vec![rule]))
+        }
+
         let bgcolor = if let Some(this) = self.downcast::<HTMLBodyElement>() {
             this.get_background_color()
         } else if let Some(this) = self.downcast::<HTMLTableElement>() {

components/style/legacy.rs

@@ -1,17 +0,0 @@
-/* This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
-
-//! Legacy presentational attributes defined in the HTML5 specification: `<td width>`,
-//! `<input size>`, and so forth.
-
-use properties::PropertyDeclaration;
-use selectors::matching::DeclarationBlock;
-use std::sync::Arc;
-
-/// A convenience function to create a declaration block from a single declaration. This is
-/// primarily used in `synthesize_rules_for_legacy_attributes`.
-#[inline]
-pub fn from_declaration(rule: PropertyDeclaration) -> DeclarationBlock<Vec<PropertyDeclaration>> {
-    DeclarationBlock::from_declarations(Arc::new(vec![rule]))
-}

components/style/lib.rs

@@ -45,7 +45,6 @@ pub mod animation;
 pub mod attr;
 mod custom_properties;
 pub mod font_face;
-pub mod legacy;
 pub mod media_queries;
 pub mod node;
 pub mod parser;