Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-29 16:19:14 +01:00
Code Issues Projects Releases Packages Wiki Activity

Remove event handlers when attribute is removed (#38734)

Browse source 
We wouldn't handle the AttributeMutation::Removed for
attribute event listeners and wouldn't remove the
corresponding event listener. Added the necessary
logic (using the newly EventTarget::is_content_event_handler
to correctly only do this for known event handlers) and
added links to the relevant parts of the spec.

Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
This commit is contained in:
Tim van der Lippe 2025-08-22 21:43:04 +02:00 • committed by GitHub
parent 1ad0ad6f25
commit f334a56b07
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
7 changed files with 38 additions and 55 deletions
Download patch file Download diff file Expand all files Collapse all files

18
tests/wpt/meta/css/css-animations/idlharness.html.ini vendored
View file

@ -1,31 +1,13 @@
[idlharness.html]
[HTMLElement interface: attribute onanimationstart]
expected: FAIL
[CSSKeyframeRule interface: keyframes.cssRules[0\] must inherit property "keyText" with the proper type]
expected: FAIL
[Window interface: attribute onanimationcancel]
expected: FAIL
[Document interface: attribute onanimationstart]
expected: FAIL
[CSSKeyframeRule interface: attribute keyText]
expected: FAIL
[Window interface: attribute onanimationstart]
expected: FAIL
[Document interface: attribute onanimationcancel]
expected: FAIL
[CSSKeyframeRule interface: attribute style]
expected: FAIL
[HTMLElement interface: attribute onanimationcancel]
expected: FAIL
[CSSKeyframesRule interface: attribute length]
expected: FAIL

6
tests/wpt/meta/dom/events/webkit-animation-start-event.html.ini vendored
View file

@ -1,14 +1,8 @@
[webkit-animation-start-event.html]
expected: TIMEOUT
[onanimationstart and onwebkitanimationstart are not aliases]
expected: FAIL
[dispatchEvent of a webkitAnimationStart event does trigger a prefixed event handler or listener]
expected: FAIL
[dispatchEvent of a webkitAnimationStart event does not trigger an unprefixed event handler or listener]
expected: FAIL
[onwebkitanimationstart event handler should trigger for an animation]
expected: TIMEOUT

18
tests/wpt/meta/html/webappapis/scripting/events/event-handler-non-content-document-idl-attributes.html.ini vendored
View file

@ -1,18 +0,0 @@
[event-handler-non-content-document-idl-attributes.html]
[div.onreadystatechange is not an event handler content attribute]
expected: FAIL
[div.onvisibilitychange is not an event handler content attribute]
expected: FAIL
[body.onreadystatechange is not an event handler content attribute]
expected: FAIL
[body.onvisibilitychange is not an event handler content attribute]
expected: FAIL
[frameset.onreadystatechange is not an event handler content attribute]
expected: FAIL
[frameset.onvisibilitychange is not an event handler content attribute]
expected: FAIL