mirror of
https://github.com/servo/servo.git
synced 2025-07-30 10:40:27 +01:00
Improve the readability of dictionaries' new() method.
This commit is contained in:
parent
edc5765978
commit
f376f9c2d7
1 changed files with 19 additions and 16 deletions
|
@ -5894,12 +5894,14 @@ class CGDictionary(CGThing):
|
||||||
def impl(self):
|
def impl(self):
|
||||||
d = self.dictionary
|
d = self.dictionary
|
||||||
if d.parent:
|
if d.parent:
|
||||||
initParent = ("parent: match try!(%s::%s::new(cx, val)) {\n"
|
initParent = ("parent: {\n"
|
||||||
|
" match try!(%s::%s::new(cx, val)) {\n"
|
||||||
" ConversionResult::Success(v) => v,\n"
|
" ConversionResult::Success(v) => v,\n"
|
||||||
" ConversionResult::Failure(error) => {\n"
|
" ConversionResult::Failure(error) => {\n"
|
||||||
" throw_type_error(cx, &error);\n"
|
" throw_type_error(cx, &error);\n"
|
||||||
" return Err(());\n"
|
" return Err(());\n"
|
||||||
" }\n"
|
" }\n"
|
||||||
|
" }\n"
|
||||||
"},\n" % (self.makeModuleName(d.parent),
|
"},\n" % (self.makeModuleName(d.parent),
|
||||||
self.makeClassName(d.parent)))
|
self.makeClassName(d.parent)))
|
||||||
else:
|
else:
|
||||||
|
@ -5999,7 +6001,7 @@ class CGDictionary(CGThing):
|
||||||
|
|
||||||
def getMemberConversion(self, memberInfo, memberType):
|
def getMemberConversion(self, memberInfo, memberType):
|
||||||
def indent(s):
|
def indent(s):
|
||||||
return CGIndenter(CGGeneric(s), 8).define()
|
return CGIndenter(CGGeneric(s), 12).define()
|
||||||
|
|
||||||
member, info = memberInfo
|
member, info = memberInfo
|
||||||
templateBody = info.template
|
templateBody = info.template
|
||||||
|
@ -6028,7 +6030,8 @@ class CGDictionary(CGThing):
|
||||||
" false => {\n"
|
" false => {\n"
|
||||||
"%s\n"
|
"%s\n"
|
||||||
" },\n"
|
" },\n"
|
||||||
"}\n}") % (member.identifier.name, indent(conversion), indent(default))
|
" }\n"
|
||||||
|
"}") % (member.identifier.name, indent(conversion), indent(default))
|
||||||
|
|
||||||
return CGGeneric(conversion)
|
return CGGeneric(conversion)
|
||||||
|
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue