Auto merge of #25598 - pshaughn:cookieexpire, r=jdm

Expire cookies on lookup

<!-- Please describe your changes on the following line: -->
Cookies were rarely, if ever, expiring; this caused tests that used max-age=0 as a cookie deletion method to have cookies they shouldn't have had.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #24911

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
This commit is contained in:
bors-servo 2020-01-25 08:48:27 -05:00 committed by GitHub
commit f3e6351e47
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 16 additions and 70 deletions

View file

@ -1,15 +0,0 @@
[cors-cookies-redirect.any.worker.html]
[Untitled]
expected: FAIL
[cors-cookies-redirect]
expected: FAIL
[cors-cookies-redirect.any.html]
[Untitled]
expected: FAIL
[cors-cookies-redirect]
expected: FAIL

View file

@ -1,26 +0,0 @@
[cors-cookies.any.html]
type: testharness
[Include mode: local cookies are not sent with remote request]
expected: FAIL
[Include mode: remote cookies are not sent with local request]
expected: FAIL
[cors-cookies.any.worker.html]
type: testharness
[Include mode: local cookies are not sent with remote request]
expected: FAIL
[Include mode: remote cookies are not sent with local request]
expected: FAIL
[Include mode: remote cookies are not sent with local request]
expected: FAIL
[Include mode: local cookies are not sent with remote request]
expected: FAIL
[cors-cookies]
expected: FAIL

View file

@ -1,29 +0,0 @@
[cookies.any.html]
type: testharness
[Include mode: 2 cookies]
expected: FAIL
[Omit mode: no cookie is stored]
expected: FAIL
[Same-origin mode: 1 cookie]
expected: FAIL
[Same-origin mode: 2 cookies]
expected: FAIL
[cookies.any.worker.html]
type: testharness
[Include mode: 2 cookies]
expected: FAIL
[Omit mode: no cookie is stored]
expected: FAIL
[Same-origin mode: 1 cookie]
expected: FAIL
[Same-origin mode: 2 cookies]
expected: FAIL