From f426b644ca179e40d009ec58afa643d1c5489af0 Mon Sep 17 00:00:00 2001 From: Jonathan Kew Date: Fri, 31 Jan 2020 10:11:19 +0000 Subject: [PATCH] style: Don't apply text-combine-upright in sideways-* writing modes. Differential Revision: https://phabricator.services.mozilla.com/D61326 --- components/style/style_adjuster.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/style/style_adjuster.rs b/components/style/style_adjuster.rs index a66c9462c92..2a897bbe151 100644 --- a/components/style/style_adjuster.rs +++ b/components/style/style_adjuster.rs @@ -281,7 +281,7 @@ impl<'a, 'b: 'a> StyleAdjuster<'a, 'b> { let writing_mode = self.style.get_inherited_box().clone_writing_mode(); let text_combine_upright = self.style.get_inherited_text().clone_text_combine_upright(); - if writing_mode != WritingMode::HorizontalTb && + if matches!(writing_mode, WritingMode::VerticalRl | WritingMode::VerticalLr) && text_combine_upright == TextCombineUpright::All { self.style.add_flags(ComputedValueFlags::IS_TEXT_COMBINED);