diff --git a/components/canvas/webgl_mode/inprocess.rs b/components/canvas/webgl_mode/inprocess.rs index d8d4b4656f1..42a4a112cee 100644 --- a/components/canvas/webgl_mode/inprocess.rs +++ b/components/canvas/webgl_mode/inprocess.rs @@ -22,23 +22,38 @@ pub struct WebGLThreads(WebGLSender); impl WebGLThreads { /// Creates a new WebGLThreads object - pub fn new(gl_factory: GLContextFactory, - webrender_gl: Rc, - webrender_api_sender: webrender_api::RenderApiSender, - webvr_compositor: Option>) - -> (WebGLThreads, Box, Option>) { + pub fn new( + gl_factory: GLContextFactory, + webrender_gl: Rc, + webrender_api_sender: webrender_api::RenderApiSender, + webvr_compositor: Option>, + ) -> ( + WebGLThreads, + Box, + Option>, + ) { // This implementation creates a single `WebGLThread` for all the pipelines. - let channel = WebGLThread::start(gl_factory, - webrender_api_sender, - webvr_compositor.map(|c| WebVRRenderWrapper(c)), - PhantomData); + let channel = WebGLThread::start( + gl_factory, + webrender_api_sender, + webvr_compositor.map(|c| WebVRRenderWrapper(c)), + PhantomData, + ); let output_handler = if PREFS.is_dom_to_texture_enabled() { - Some(Box::new(OutputHandler::new(webrender_gl.clone(), channel.clone()))) + Some(Box::new(OutputHandler::new( + webrender_gl.clone(), + channel.clone(), + ))) } else { None }; - let external = WebGLExternalImageHandler::new(WebGLExternalImages::new(webrender_gl, channel.clone())); - (WebGLThreads(channel), Box::new(external), output_handler.map(|b| b as Box<_>)) + let external = + WebGLExternalImageHandler::new(WebGLExternalImages::new(webrender_gl, channel.clone())); + ( + WebGLThreads(channel), + Box::new(external), + output_handler.map(|b| b as Box<_>), + ) } /// Gets the WebGLThread handle for each script pipeline. @@ -49,7 +64,9 @@ impl WebGLThreads { /// Sends a exit message to close the WebGLThreads and release all WebGLContexts. pub fn exit(&self) -> Result<(), &'static str> { - self.0.send(WebGLMsg::Exit).map_err(|_| "Failed to send Exit message") + self.0 + .send(WebGLMsg::Exit) + .map_err(|_| "Failed to send Exit message") } } @@ -58,7 +75,10 @@ struct WebGLExternalImages { webrender_gl: Rc, webgl_channel: WebGLSender, // Used to avoid creating a new channel on each received WebRender request. - lock_channel: (WebGLSender<(u32, Size2D, usize)>, WebGLReceiver<(u32, Size2D, usize)>), + lock_channel: ( + WebGLSender<(u32, Size2D, usize)>, + WebGLReceiver<(u32, Size2D, usize)>, + ), } impl WebGLExternalImages { @@ -75,12 +95,15 @@ impl WebGLExternalImageApi for WebGLExternalImages { fn lock(&mut self, ctx_id: WebGLContextId) -> (u32, Size2D) { // WebGL Thread has it's own GL command queue that we need to synchronize with the WR GL command queue. // The WebGLMsg::Lock message inserts a fence in the WebGL command queue. - self.webgl_channel.send(WebGLMsg::Lock(ctx_id, self.lock_channel.0.clone())).unwrap(); + self.webgl_channel + .send(WebGLMsg::Lock(ctx_id, self.lock_channel.0.clone())) + .unwrap(); let (image_id, size, gl_sync) = self.lock_channel.1.recv().unwrap(); // The next glWaitSync call is run on the WR thread and it's used to synchronize the two // flows of OpenGL commands in order to avoid WR using a semi-ready WebGL texture. // glWaitSync doesn't block WR thread, it affects only internal OpenGL subsystem. - self.webrender_gl.wait_sync(gl_sync as gl::GLsync, 0, gl::TIMEOUT_IGNORED); + self.webrender_gl + .wait_sync(gl_sync as gl::GLsync, 0, gl::TIMEOUT_IGNORED); (image_id, size) } @@ -92,11 +115,17 @@ impl WebGLExternalImageApi for WebGLExternalImages { /// Custom observer used in a `WebGLThread`. impl WebGLThreadObserver for PhantomData<()> { fn on_context_create(&mut self, ctx_id: WebGLContextId, texture_id: u32, size: Size2D) { - debug!("WebGLContext created (ctx_id: {:?} texture_id: {:?} size: {:?}", ctx_id, texture_id, size); + debug!( + "WebGLContext created (ctx_id: {:?} texture_id: {:?} size: {:?}", + ctx_id, texture_id, size + ); } fn on_context_resize(&mut self, ctx_id: WebGLContextId, texture_id: u32, size: Size2D) { - debug!("WebGLContext resized (ctx_id: {:?} texture_id: {:?} size: {:?}", ctx_id, texture_id, size); + debug!( + "WebGLContext resized (ctx_id: {:?} texture_id: {:?} size: {:?}", + ctx_id, texture_id, size + ); } fn on_context_delete(&mut self, ctx_id: WebGLContextId) { @@ -104,7 +133,6 @@ impl WebGLThreadObserver for PhantomData<()> { } } - /// Wrapper to send WebVR commands used in `WebGLThread`. struct WebVRRenderWrapper(Box); @@ -120,7 +148,10 @@ struct OutputHandler { webrender_gl: Rc, webgl_channel: WebGLSender, // Used to avoid creating a new channel on each received WebRender request. - lock_channel: (WebGLSender, WebGLReceiver), + lock_channel: ( + WebGLSender, + WebGLReceiver, + ), sync_objects: FnvHashMap, } @@ -137,14 +168,24 @@ impl OutputHandler { /// Bridge between the WR frame outputs and WebGL to implement DOMToTexture synchronization. impl webrender::OutputImageHandler for OutputHandler { - fn lock(&mut self, id: webrender_api::PipelineId) -> Option<(u32, webrender_api::DeviceIntSize)> { + fn lock( + &mut self, + id: webrender_api::PipelineId, + ) -> Option<(u32, webrender_api::DeviceIntSize)> { // Insert a fence in the WR command queue - let gl_sync = self.webrender_gl.fence_sync(gl::SYNC_GPU_COMMANDS_COMPLETE, 0); + let gl_sync = self + .webrender_gl + .fence_sync(gl::SYNC_GPU_COMMANDS_COMPLETE, 0); // The lock command adds a WaitSync call on the WebGL command flow. let command = DOMToTextureCommand::Lock(id, gl_sync as usize, self.lock_channel.0.clone()); - self.webgl_channel.send(WebGLMsg::DOMToTextureCommand(command)).unwrap(); + self.webgl_channel + .send(WebGLMsg::DOMToTextureCommand(command)) + .unwrap(); self.lock_channel.1.recv().unwrap().map(|(tex_id, size)| { - (tex_id, webrender_api::DeviceIntSize::new(size.width, size.height)) + ( + tex_id, + webrender_api::DeviceIntSize::new(size.width, size.height), + ) }) } diff --git a/components/canvas_traits/webgl_channel/ipc.rs b/components/canvas_traits/webgl_channel/ipc.rs index ac3020bbc7a..a00ceda75ed 100644 --- a/components/canvas_traits/webgl_channel/ipc.rs +++ b/components/canvas_traits/webgl_channel/ipc.rs @@ -9,7 +9,7 @@ use std::io; pub type WebGLSender = ipc_channel::ipc::IpcSender; pub type WebGLReceiver = ipc_channel::ipc::IpcReceiver; -pub fn webgl_channel Deserialize<'de>>() - -> Result<(WebGLSender, WebGLReceiver), io::Error> { +pub fn webgl_channel Deserialize<'de>>( +) -> Result<(WebGLSender, WebGLReceiver), io::Error> { ipc_channel::ipc::channel() } diff --git a/components/canvas_traits/webgl_channel/mod.rs b/components/canvas_traits/webgl_channel/mod.rs index c7376501049..f317d116f3d 100644 --- a/components/canvas_traits/webgl_channel/mod.rs +++ b/components/canvas_traits/webgl_channel/mod.rs @@ -13,9 +13,7 @@ use servo_config::opts; use std::fmt; lazy_static! { - static ref IS_MULTIPROCESS: bool = { - opts::multiprocess() - }; + static ref IS_MULTIPROCESS: bool = { opts::multiprocess() }; } #[derive(Clone, Deserialize, Serialize)] @@ -34,41 +32,42 @@ impl WebGLSender { #[inline] pub fn send(&self, msg: T) -> WebGLSendResult { match *self { - WebGLSender::Ipc(ref sender) => { - sender.send(msg).map_err(|_| ()) - }, - WebGLSender::Mpsc(ref sender) => { - sender.send(msg).map_err(|_| ()) - } + WebGLSender::Ipc(ref sender) => sender.send(msg).map_err(|_| ()), + WebGLSender::Mpsc(ref sender) => sender.send(msg).map_err(|_| ()), } } } pub type WebGLSendResult = Result<(), ()>; -pub enum WebGLReceiver where T: for<'de> Deserialize<'de> + Serialize { +pub enum WebGLReceiver +where + T: for<'de> Deserialize<'de> + Serialize, +{ Ipc(ipc::WebGLReceiver), Mpsc(mpsc::WebGLReceiver), } -impl WebGLReceiver where T: for<'de> Deserialize<'de> + Serialize { +impl WebGLReceiver +where + T: for<'de> Deserialize<'de> + Serialize, +{ pub fn recv(&self) -> Result { match *self { - WebGLReceiver::Ipc(ref receiver) => { - receiver.recv().map_err(|_| ()) - }, - WebGLReceiver::Mpsc(ref receiver) => { - receiver.recv().map_err(|_| ()) - } + WebGLReceiver::Ipc(ref receiver) => receiver.recv().map_err(|_| ()), + WebGLReceiver::Mpsc(ref receiver) => receiver.recv().map_err(|_| ()), } } } pub fn webgl_channel() -> Result<(WebGLSender, WebGLReceiver), ()> - where T: for<'de> Deserialize<'de> + Serialize { +where + T: for<'de> Deserialize<'de> + Serialize, +{ if *IS_MULTIPROCESS { - ipc::webgl_channel().map(|(tx, rx)| (WebGLSender::Ipc(tx), WebGLReceiver::Ipc(rx))) - .map_err(|_| ()) + ipc::webgl_channel() + .map(|(tx, rx)| (WebGLSender::Ipc(tx), WebGLReceiver::Ipc(rx))) + .map_err(|_| ()) } else { mpsc::webgl_channel().map(|(tx, rx)| (WebGLSender::Mpsc(tx), WebGLReceiver::Mpsc(rx))) } diff --git a/components/canvas_traits/webgl_channel/mpsc.rs b/components/canvas_traits/webgl_channel/mpsc.rs index b0fe29241f3..79988835b6c 100644 --- a/components/canvas_traits/webgl_channel/mpsc.rs +++ b/components/canvas_traits/webgl_channel/mpsc.rs @@ -17,7 +17,9 @@ macro_rules! unreachable_serializable { impl<'a, T> Deserialize<'a> for $name { fn deserialize(_: D) -> Result<$name, D::Error> - where D: Deserializer<'a> { + where + D: Deserializer<'a>, + { unreachable!(); } }