Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 13:40:08 +01:00
Code Issues Projects Releases Packages Wiki Activity

style: Remove StyleClear::Line

Browse source 
Before this patch, StyleClear::Line indicates that the nsLineBox has break-after
but no float clearance (note we don't allow line break-before with clear:none);
StyleClear::None indicates the line has no break-before nor break-after.

In this patch, I added `mHasForcedLineBreak` bit in nsLineBox to indicate the
line has a break so that StyleClear can serve its original meaning -- the float
clearance. In Part 6, I'll rename more existing methods and variables related to
float clearance.

Now, instead of using StyleClear::None to clear the line break status, the
caller should use ClearForcedLineBreak(); Similar to set
SetInlineLineBreakBeforeAndReset() and SetInlineLineBreakAfter on
nsReflowStatus, SetBreakTypeBefore/SetBreakTypeAfter on nsLineBox always sets
break status with an optional float clearance parameter.

This patch shouldn't change the behavior.

Differential Revision: https://phabricator.services.mozilla.com/D158224
This commit is contained in:
Ting-Yu Lin 2022-09-29 03:40:55 +00:00 • committed by Martin Robinson
parent 3da52edffc
commit f4e10192ca
1 changed files with 0 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
components/style/properties/gecko.mako.rs
View file

@ -1164,7 +1164,6 @@ fn static_assert() {
"clear", "clear",
"Left Right None Both", "Left Right None Both",
gecko_enum_prefix="StyleClear", gecko_enum_prefix="StyleClear",
gecko_inexhaustive=True,
) %> ) %>
${impl_keyword('clear', 'mBreakType', clear_keyword)} ${impl_keyword('clear', 'mBreakType', clear_keyword)}
</%self:impl_trait> </%self:impl_trait>