Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-18 19:08:22 +01:00
Code Issues Projects Releases Packages Wiki Activity

webdriver: Remove TODO comments of focusing steps (#39366)

Browse source 
Our current implementation already gets the "TODO" done for focusing
steps.


https://searchfox.org/firefox-main/source/dom/html/nsGenericHTMLElement.cpp#3491-3497

Testing: No. Just updating comments

Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
This commit is contained in:
Euclid Ye 2025-09-18 14:54:49 +08:00 • committed by GitHub
parent 975ca3a3f6
commit f508b1e5af
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 0 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
components/script/webdriver_handlers.rs
View file

@ -1285,8 +1285,6 @@ pub(crate) fn handle_will_send_keys(
// run the focusing steps for the element.
if let Some(html_element) = element.downcast::<HTMLElement>() {
if !element.is_active_element() {
// TODO: "Focusing steps" has a different meaning from the focus() method.
// The actual focusing steps should be implemented
html_element.Focus(
&FocusOptions {
preventScroll: true,
@ -1830,8 +1828,6 @@ fn clear_a_resettable_element(element: &Element, can_gc: CanGc) -> Result<(), Er
}
// Step 3. Invoke the focusing steps for the element.
// TODO: "Focusing steps" has a different meaning from the focus() method.
// The actual focusing steps should be implemented
html_element.Focus(
&FocusOptions {
preventScroll: true,
@ -1989,8 +1985,6 @@ pub(crate) fn handle_element_click(
// Step 8.5
match container.downcast::<HTMLElement>() {
Some(html_element) => {
// TODO: "Focusing steps" has a different meaning from the focus() method.
// The actual focusing steps should be implemented
html_element.Focus(
&FocusOptions {
preventScroll: true,