mirror of
https://github.com/servo/servo.git
synced 2025-08-01 03:30:33 +01:00
Auto merge of #26143 - jdm:transform-feedback, r=nox
Fix webgl transform feedback This allows https://www.joshmatthews.net/webxr-particles/ to run in Servo. This change corresponds with the following spec text: ``` GL_INVALID_OPERATION is generated by glBeginTransformFeedback if no binding points would be used, either because no program object is active of because the active program object has specified no varying variables to record. ``` --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #26137 - [x] There are tests for these changes
This commit is contained in:
commit
f6f2b493f6
6 changed files with 29 additions and 224 deletions
|
@ -3456,7 +3456,7 @@ impl WebGL2RenderingContextMethods for WebGL2RenderingContext {
|
|||
return;
|
||||
},
|
||||
};
|
||||
if !program.is_linked() || program.transform_feedback_varyings_length() != 0 {
|
||||
if !program.is_linked() || program.transform_feedback_varyings_length() == 0 {
|
||||
self.base.webgl_error(InvalidOperation);
|
||||
return;
|
||||
};
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue