Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-10-02 09:39:14 +01:00
Code Issues Projects Releases Packages Wiki Activity

layout: Let min/max constraints avoid collapsing bottom margins (#36322)

Browse source 
When `block-size` was intrinsic and there was no block-end padding or
margin, we were allowing the block-end margin of the box to collapse
with the block-end margin of its contents.

However, due to `min-block-size` or `max-block-size`, the final size can
be different than the intrinsic size of the contents. In that case it
didn't make any sense to collapse end margins, only WebKit does it too.

This patch takes the final size into account, like Gecko and Blink. This
is under discussion in https://github.com/w3c/csswg-drafts/issues/12218,
but for now we will match Blink.

Testing: 2 tests are now passing. There is also 1 new failure, but that
test only passes in WebKit and I don't agree with it.

Fixes: #36321

Signed-off-by: Oriol Brufau <obrufau@igalia.com>
This commit is contained in:
Oriol Brufau 2025-09-30 18:12:31 +02:00 • committed by GitHub
parent 439558133f
commit f724651e1a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 28 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

2
tests/wpt/meta/css/CSS2/margin-padding-clear/margin-collapse-038.xht.ini vendored Normal file
View file

@ -0,0 +1,2 @@
[margin-collapse-038.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/normal-flow/max-height-separates-margin.html.ini vendored
View file

@ -1,2 +0,0 @@
[max-height-separates-margin.html]
expected: FAIL

2
tests/wpt/meta/css/CSS2/normal-flow/min-height-separates-margin.html.ini vendored
View file

@ -1,2 +0,0 @@
[min-height-separates-margin.html]
expected: FAIL