Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-07 06:25:32 +01:00
Code Issues Projects Releases Packages Wiki Activity

Reduce redundancy in servoshell webdriver message forwarding and add log for script::handle_send_keys_non_typeable (#38238)

Browse source 
There was a new commit for after
https://github.com/servo/servo/pull/38189#discussion_r2224805172, but
that does not seem to update/stop MQ.
Also removed `forward_webdriver_command` in servoshell according to
https://github.com/servo/servo/pull/38212#discussion_r2221854327.

---------

Signed-off-by: Euclid Ye <euclid.ye@huawei.com>
This commit is contained in:
Euclid Ye 2025-07-24 12:22:04 +08:00 • committed by GitHub
parent 6ace7ad577
commit f726737f24
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
9 changed files with 16 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

18
ports/servoshell/desktop/app.rs
View file

@ -353,7 +353,7 @@ impl App {
while let Ok(msg) = webdriver_receiver.try_recv() {
match msg {
WebDriverCommandMsg::SetWebDriverResponseSender(..) => {
running_state.forward_webdriver_command(msg);
running_state.servo().execute_webdriver_command(msg);
},
WebDriverCommandMsg::IsWebViewOpen(webview_id, sender) => {
let context = running_state.webview_by_id(webview_id);
@ -363,7 +363,7 @@ impl App {
}
},
WebDriverCommandMsg::IsBrowsingContextOpen(..) => {
running_state.forward_webdriver_command(msg);
running_state.servo().execute_webdriver_command(msg);
},
WebDriverCommandMsg::NewWebView(response_sender, load_status_sender) => {
let new_webview =
@ -580,15 +580,9 @@ impl App {
webview.notify_scroll_event(scroll_location, point.to_i32());
}
},
WebDriverCommandMsg::ScriptCommand(
browsing_context_id,
webdriver_script_command,
) => {
self.handle_webdriver_script_commnd(&webdriver_script_command, running_state);
running_state.forward_webdriver_command(WebDriverCommandMsg::ScriptCommand(
browsing_context_id,
webdriver_script_command,
));
WebDriverCommandMsg::ScriptCommand(_, ref webdriver_script_command) => {
self.handle_webdriver_script_commnd(webdriver_script_command, running_state);
running_state.servo().execute_webdriver_command(msg);
},
WebDriverCommandMsg::CurrentUserPrompt(webview_id, response_sender) => {
let current_dialog =
@ -637,7 +631,7 @@ impl App {
running_state.set_alert_text_of_newest_dialog(webview_id, text);
},
WebDriverCommandMsg::TakeScreenshot(..) => {
running_state.forward_webdriver_command(msg);
running_state.servo().execute_webdriver_command(msg);
},
};
}

4
ports/servoshell/desktop/app_state.rs
View file

@ -159,10 +159,6 @@ impl RunningAppState {
self.webdriver_receiver.as_ref()
}
pub(crate) fn forward_webdriver_command(&self, command: WebDriverCommandMsg) {
self.servo().execute_webdriver_command(command);
}
pub(crate) fn hidpi_scale_factor_changed(&self) {
let inner = self.inner();
let new_scale_factor = inner.window.hidpi_scale_factor();