mirror of
https://github.com/servo/servo.git
synced 2025-06-13 19:04:30 +00:00
Auto merge of #16550 - froydnj:gecko-bindings-gecko-debug, r=froydnj
switch gecko_bindings over to the gecko_debug feature [DO NOT MERGE] ...so that they use the correct Gecko structs regardless of whether Rust code is being compiled with debug assertions or not. This is the second part of the Servo-side changes for https://bugzilla.mozilla.org/show_bug.cgi?id=1357556 - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because building is a sufficient test. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16550) <!-- Reviewable:end -->
This commit is contained in:
commit
f795eb1a8b
7 changed files with 16 additions and 8 deletions
|
@ -417,8 +417,9 @@ class MachCommands(CommandBase):
|
|||
|
||||
ret = None
|
||||
opts = []
|
||||
features = []
|
||||
if with_gecko is not None:
|
||||
opts += ["--features", "bindgen"]
|
||||
features += ["bindgen"]
|
||||
env["MOZ_DIST"] = path.abspath(path.expanduser(with_gecko))
|
||||
if jobs is not None:
|
||||
opts += ["-j", jobs]
|
||||
|
@ -426,6 +427,11 @@ class MachCommands(CommandBase):
|
|||
opts += ["-v"]
|
||||
if release:
|
||||
opts += ["--release"]
|
||||
else:
|
||||
features += ["gecko_debug"]
|
||||
|
||||
if features:
|
||||
opts += ["--features", ' '.join(features)]
|
||||
|
||||
if with_gecko is not None:
|
||||
print("Generating atoms data...")
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue