Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-20 15:18:58 +01:00
Code Issues Projects Releases Packages Wiki Activity

Unrevert the fix for hit testing through shadows

Browse source 
This was originally #9428 but got accidentally reverted during rebase in

Fixes #9865.
This commit is contained in:
Jack Moffitt 2016-03-03 17:04:55 -07:00
parent 55fc48e4c4
commit f7aa6a32e9
1 changed files with 19 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

31
components/gfx/display_list/mod.rs
View file

@ -1314,23 +1314,30 @@ impl DisplayItem {
return;
}
if let DisplayItem::BorderClass(ref border) = *self {
// If the point is inside the border, it didn't hit the border!
let interior_rect =
Rect::new(
Point2D::new(border.base.bounds.origin.x +
border.border_widths.left,
border.base.bounds.origin.y +
border.border_widths.top),
Size2D::new(border.base.bounds.size.width -
match *self {
DisplayItem::BorderClass(ref border) => {
// If the point is inside the border, it didn't hit the border!
let interior_rect =
Rect::new(
Point2D::new(border.base.bounds.origin.x +
border.border_widths.left,
border.base.bounds.origin.y +
border.border_widths.top),
Size2D::new(border.base.bounds.size.width -
(border.border_widths.left +
border.border_widths.right),
border.base.bounds.size.height -
border.base.bounds.size.height -
(border.border_widths.top +
border.border_widths.bottom)));
if interior_rect.contains(&point) {
return;
if interior_rect.contains(&point) {
return;
}
}
DisplayItem::BoxShadowClass(_) => {
// Box shadows can never be hit.
return
}
_ => {}
}
// We found a hit!