Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 12:40:06 +01:00
Code Issues Projects Releases Packages Wiki Activity

Add parsing of overflow: scroll and auto.

Browse source 
Elements with overflow scroll/auto are not yet scrollable, but they will be
clipped correctly (like `overflow: hidden`).
This commit is contained in:
Matt Brubeck 2014-06-20 12:21:15 -07:00
parent 21e4d85511
commit f7e371fdfd
5 changed files with 56 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/components/layout/fragment.rs
View file

@ -1395,9 +1395,12 @@ impl Fragment {
}
}
/// Returns true if the contents should be clipped (i.e. if `overflow` is `hidden`).
/// Returns true if the contents should be clipped (i.e. if `overflow` is not `visible`).
pub fn needs_clip(&self) -> bool {
self.style().get_box().overflow == overflow::hidden
match self.style().get_box().overflow {
overflow::visible => true,
overflow::hidden | overflow::auto | overflow::scroll => false,
}
}
/// A helper function to return a debug string describing the side offsets for one of the rect
@ -1475,13 +1478,13 @@ impl ChildDisplayListAccumulator {
-> ChildDisplayListAccumulator {
ChildDisplayListAccumulator {
clip_display_item: match style.get_box().overflow {
overflow::hidden => {
overflow::hidden | overflow::auto | overflow::scroll => {
Some(box ClipDisplayItem {
base: BaseDisplayItem::new(bounds, node, level),
children: DisplayList::new(),
})
}
_ => None,
},
overflow::visible => None,
}
}
}

2
src/components/style/properties/mod.rs.mako
View file

@ -515,7 +515,7 @@ pub mod longhands {
// CSS 2.1, Section 11 - Visual effects
${single_keyword("overflow", "visible hidden")} // TODO: scroll auto
${single_keyword("overflow", "visible hidden scroll auto")}
${switch_to_style_struct("InheritedBox")}

3
src/test/ref/basic.list
View file

@ -76,6 +76,9 @@
== linebreak_simple_a.html linebreak_simple_b.html
== linebreak_inline_span_a.html linebreak_inline_span_b.html
== overconstrained_block.html overconstrained_block_ref.html
== overflow_auto.html overflow_simple_b.html
== overflow_scroll.html overflow_simple_b.html
== overflow_simple_a.html overflow_simple_b.html
== position_fixed_background_color_a.html position_fixed_background_color_b.html
== position_fixed_overflow_a.html position_fixed_overflow_b.html
== noscript.html noscript_ref.html

22
src/test/ref/overflow_auto.html Normal file
View file

@ -0,0 +1,22 @@
<html>
<head>
<style>
#first {
height: 100px;
width: 100px;
overflow: auto;
}
#second {
height: 100px;
width: 200px;
background: green;
}
</style>
</head>
<body>
<div id="first">
<div id="second">
</div>
</div>
</body>
</html>

22
src/test/ref/overflow_scroll.html Normal file
View file

@ -0,0 +1,22 @@
<html>
<head>
<style>
#first {
height: 100px;
width: 100px;
overflow: scroll;
}
#second {
height: 100px;
width: 200px;
background: green;
}
</style>
</head>
<body>
<div id="first">
<div id="second">
</div>
</div>
</body>
</html>