From f8121ae60d691397d4173af2ac39fcf736bc84dd Mon Sep 17 00:00:00 2001 From: Michael Howell Date: Tue, 6 Dec 2016 00:42:29 +0000 Subject: [PATCH] Fix "a serious bug" in the `bind_to_tree` functions --- components/script/dom/htmlheadelement.rs | 5 ++++- components/script/dom/htmltitleelement.rs | 7 +++++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/components/script/dom/htmlheadelement.rs b/components/script/dom/htmlheadelement.rs index 419644c5bb3..fc6e888d015 100644 --- a/components/script/dom/htmlheadelement.rs +++ b/components/script/dom/htmlheadelement.rs @@ -71,7 +71,10 @@ impl VirtualMethods for HTMLHeadElement { fn super_type(&self) -> Option<&VirtualMethods> { Some(self.upcast::() as &VirtualMethods) } - fn bind_to_tree(&self, _tree_in_doc: bool) { + fn bind_to_tree(&self, tree_in_doc: bool) { + if let Some(ref s) = self.super_type() { + s.bind_to_tree(tree_in_doc); + } load_script(self); } } diff --git a/components/script/dom/htmltitleelement.rs b/components/script/dom/htmltitleelement.rs index c124a4a3604..f3ec357cb56 100644 --- a/components/script/dom/htmltitleelement.rs +++ b/components/script/dom/htmltitleelement.rs @@ -71,9 +71,12 @@ impl VirtualMethods for HTMLTitleElement { } } - fn bind_to_tree(&self, is_in_doc: bool) { + fn bind_to_tree(&self, tree_in_doc: bool) { + if let Some(ref s) = self.super_type() { + s.bind_to_tree(tree_in_doc); + } let node = self.upcast::(); - if is_in_doc { + if tree_in_doc { node.owner_doc().title_changed(); } }