Auto merge of #19772 - ferjm:performance.wpt, r=nox

Do not fire pending callbacks on disconnected performance observer

Implement this change in the Performance Timeline API https://github.com/w3c/performance-timeline/issues/66

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19772)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2018-01-15 03:20:57 -06:00 committed by GitHub
commit f866e1aacb
2 changed files with 0 additions and 19 deletions

View file

@ -184,14 +184,6 @@ impl Performance {
None => return,
};
if self.pending_notification_observers_task.get() {
if let Some(o) = observers.iter().nth(index) {
DOMPerformanceObserver::new(&self.global(),
o.observer.callback(),
o.observer.entries()).notify();
}
}
observers.remove(index);
}

View file

@ -1,11 +0,0 @@
[po-disconnect.any.html]
type: testharness
[An observer disconnected after a mark must not have its callback invoked]
expected: FAIL
[po-disconnect.any.worker.html]
type: testharness
[An observer disconnected after a mark must not have its callback invoked]
expected: FAIL